Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: Remaining bits after both user and room settings are implemented #8207

Closed
36 of 40 tasks
turt2live opened this issue Jan 21, 2019 · 11 comments
Closed
36 of 40 tasks

Comments

@turt2live
Copy link
Member

turt2live commented Jan 21, 2019

Part 0 (already fixed prior to grouping):

Part 1 (PR: matrix-org/matrix-react-sdk#2526):

Part 2 (PR: matrix-org/matrix-react-sdk#2549):

Part 3 (PR: matrix-org/matrix-react-sdk#2553):

Part 4 (PR: matrix-org/matrix-react-sdk#2554):

  • Removing temporary tab for visiting old settings
  • Removing the old user settings entirely
  • Removing the old room settings entirely
  • Remove labs flag

Priority 2 problems ("would be really nice if..." items):

Priority 3 problems ("if someone gets bored and has time..." items):

Priority 4 problems ("Eventually, we will fix..." items):

@turt2live turt2live self-assigned this Jan 21, 2019
@turt2live turt2live changed the title Redesign: Clean up user settings after all tabs are complete Redesign: Clean up user settings after both user and room settings are implemented Jan 24, 2019
@turt2live turt2live changed the title Redesign: Clean up user settings after both user and room settings are implemented Redesign: Remaining bits after both user and room settings are implemented Jan 24, 2019
@lampholder
Copy link
Member

  • Fix the Settings title and the modal close X in position
  • Slightly increase the space between settings
  • Make the devices list less jumpy when you select a checkbox
  • Style the device names in the device list so that they look editable
  • Hide the theme dropdown (since it can't be changed and looks pretty broken atm [macOS, firefox])
    image
  • SUBJECTIVE: I think the tabs and the icons look a bit small
  • SUBJECTIVE: I think the default settings font is small, especially next to the relatively large toggles
  • SUGGESTION: let's move flair to its own tab, not because it makes sense, but because it lets us put a slow-loading bit of UI off the main path

@turt2live
Copy link
Member Author

@lampholder feedback incorporated into the main post.

On the specific items:

Hide the theme dropdown (since it can't be changed and looks pretty broken atm [macOS, firefox])

See #8249

let's move flair to its own tab, not because it makes sense, but because it lets us put a slow-loading bit of UI off the main path

I've opened this as #8268 (as per our discussion)

Make the devices list less jumpy when you select a checkbox
Style the device names in the device list so that they look editable

Both of these I've put under "fix the device table design" (it's squishy, and that causes a lot of problems)

@lampholder
Copy link
Member

Having thought about the device list UI a little over the past few days, I've uploaded my most recent sketch of a cards-based device list #8319

@lampholder
Copy link
Member

I've also spotted another UX issue - when the flow returns a user to settings after they've diverted elsewhere (via the E2E beta warning modal when enabling encryption in a room, or via the key backup UX when configuring key backup on an account) the user lands on the first page of settings, not the page they were on before.

How easy is this to fix? It's certainly jarring landing on an unexpected page, but I can also see it might be tricky to address quickly.

@lampholder
Copy link
Member

lampholder commented Jan 30, 2019

And one more issue - I don't think it's possible to delete an avatar any more. I'd suggest putting the delete X we have in other places as close as possible to the avatar square (with the 'Remove Avatar' tooltip we have in the /app build of riot)

@lampholder
Copy link
Member

And another one - can we enable Esc closing the settings modal?

@turt2live
Copy link
Member Author

How easy is this to fix? It's certainly jarring landing on an unexpected page, but I can also see it might be tricky to address quickly.

I'd rather not fix our dialog system this week, and would classify the problem as Very Hard to fix.

And another one - can we enable Esc closing the settings modal?

Already planned by proxy for Part 2 fixes.

@turt2live
Copy link
Member Author

I'd suggest putting the delete X we have in other places as close as possible to the avatar square (with the 'Remove Avatar' tooltip we have in the /app build of riot)

We should avoid an X at all costs - it confuses everyone. I'd like to get Nad in on this decision.

@turt2live
Copy link
Member Author

Removing avatars is being tracked outside of this: #8456

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 8, 2019
@turt2live
Copy link
Member Author

I'm considering this done enough to take it off my top priority list. The remaining work I've shuffled into "p4" (which is relative to the items on this issue). I've also made a note to come back to it in a few months if we haven't managed to make our way around to it.

@turt2live
Copy link
Member Author

I think most of this is now just bugs or things we fixed by changing the design (accidentally and sometimes on purpose). Closing in favour of the already-open issues.

We also don't really use epics like this anymore, so this is potentially lost to time 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants