This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Maintenance: Clean up some stuff around settings #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a technical bug where one could drag a community from the settings to the LLP
turt2live
changed the title
40 tasks
bwindels
reviewed
Feb 25, 2019
| @import "./views/settings/tabs/_SettingsTab.scss"; | ||
| @import "./views/settings/tabs/_VoiceSettingsTab.scss"; | ||
| @import "./views/settings/tabs/room/_GeneralRoomSettingsTab.scss"; | ||
| @import "./views/settings/tabs/room/_RolesRoomSettingsTab.scss"; |
There was a problem hiding this comment.
nit: IMO settings/room/tabs and settings/user/tabs would make more sense.
There was a problem hiding this comment.
That sounds like a good improvement to make if we ever get rid of room_settings being a thing elsewhere (which I also want to do, but not right now)
There was a problem hiding this comment.
Have opened element-hq/element-web#8934 to track this
bwindels
approved these changes
Feb 25, 2019
|
Merging because I'm confident the build will pass and I'm losing patience with waiting 2 hours for a build. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8864
Removes need for
DragDropContextover flair settingsFixes a technical bug where one could drag groups from settings over the LLP
Part of element-hq/element-web#8207
Note: It might be easiest to review this commit-by-commit