Add instructions for changing translated strings #6528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instructions to the developer documentation for proper housekeeping of the translations when editing strings.
|
We have |
As per code review feedback, we should use the npm run scripts i18n and i18n-prune instead of editing the i18n JSON files directly.
Replace an inline, parenthetical note about possible failures of the `npm run` scripts with additional items in the Requirements section.
aidalgol
commented
Apr 21, 2018
|
Ah, it doesn't have a hyphen so actually it's Also, do you think it makes more sense to add the bit about editing after 'adding new strings'? Most of the time people will be adding strings I suspect, rather than editing existing ones. |
The `npm run` command `i18n-prune` is actually `prunei18n`.
Move "Editing existing strings" to after "Adding new strings".
I don't have a strong preference on the ordering. I have so far found myself editing more strings than adding new strings, |
dbkr
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions to the developer documentation for proper housekeeping of the
translations when editing strings.
Signed-off-by: Aidan Gauland aidalgol+ghpr@fastmail.net