Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for changing translated strings #6528

Merged
merged 5 commits into from
May 16, 2018
Merged

Add instructions for changing translated strings #6528

merged 5 commits into from
May 16, 2018

Commits on Apr 15, 2018

  1. Add instructions for changing translated strings 

    Add instructions to the developer documentation for proper housekeeping of the
translations when editing strings.
    @aidalgol
    aidalgol committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    69bb020 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2018

  1. Correct instructions to use the i18n scripts 

    As per code review feedback, we should use the npm run scripts i18n and
i18n-prune instead of editing the i18n JSON files directly.
    @aidalgol
    aidalgol committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    6d74d5f View commit details
    Browse the repository at this point in the history

  2. Move and reword note about out-of-date dev setup 

    Replace an inline, parenthetical note about possible failures of the `npm run`
scripts with additional items in the Requirements section.
    @aidalgol
    aidalgol committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    a8e578f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2018

  1. Correct npm command name in documentation 

    The `npm run` command `i18n-prune` is actually `prunei18n`.
    @aidalgol
    aidalgol committed Apr 29, 2018
    Configuration menu
    Copy the full SHA
    c26cde2 View commit details
    Browse the repository at this point in the history

  2. Reorder sections in translating documentation 

    Move "Editing existing strings" to after "Adding new strings".
    @aidalgol
    aidalgol committed Apr 29, 2018
    Configuration menu
    Copy the full SHA
    95b09cd View commit details
    Browse the repository at this point in the history