Skip to content
This repository has been archived by the owner on Oct 25, 2019. It is now read-only.

Fix: js dependency bump #493

Merged
merged 7 commits into from
Sep 26, 2019
Merged

Fix: js dependency bump #493

merged 7 commits into from
Sep 26, 2019

Conversation

lsh-0
Copy link
Contributor

@lsh-0 lsh-0 commented Sep 13, 2019

No description provided.

@lsh-0
Copy link
Contributor Author

lsh-0 commented Sep 13, 2019

I did a npm install and then an npm update then went through all of the security alerts and matched them to changes in the lock file. About half were satisfied and two were not present at all. The other half I added to the devDependencies section and ran npm install again.

Two dependencies are not present at all and I'm not sure what to do about them:

"dependencies": {
  "nwmatcher": ">=1.4.4"
}

"dependencies": {
  "macaddress": ">=0.2.9"
}

but I figure we'll get this very large change through and then figure those ones out.

@de-code
Copy link
Collaborator

de-code commented Sep 13, 2019

Thank you for looking into this.

I upgraded webpack-cli. It is getting further but still failing.

@de-code
Copy link
Collaborator

de-code commented Sep 13, 2019

it should pass ci now but at least locally isn't actually working yet.

@de-code
Copy link
Collaborator

de-code commented Sep 13, 2019

It breaks with: zilverline/react-tap-event-plugin#121

@lsh-0
Copy link
Contributor Author

lsh-0 commented Sep 13, 2019

nice catch

@de-code
Copy link
Collaborator

de-code commented Sep 13, 2019

There are currently no end-to-end tests for the client. Therefore I would always sanity check any client library upgrades.

(There are end-to-end tests for the ETL though and smoke test for the Python server)

@de-code
Copy link
Collaborator

de-code commented Sep 13, 2019

The client seems to be superficially working now. I somehow wiped my local data volume. I am running the ETL again to check it with actual data. This might take a while though.

@de-code
Copy link
Collaborator

de-code commented Sep 13, 2019

Actually the ETL fails due to: https://github.com/elifesciences/issues/issues/5079 (which also failed in ci)

@de-code
Copy link
Collaborator

de-code commented Sep 18, 2019

No update yet, I think I will focus on it after next Wed when I may do some other work on PeerScout. (https://github.com/elifesciences/issues/issues/5079 should be fixed first)

@lsh-0
Copy link
Contributor Author

lsh-0 commented Sep 20, 2019

Thank you for the update, @de-code , we get bugged daily about it from github

@de-code
Copy link
Collaborator

de-code commented Sep 26, 2019

Almost surprisingly this actually still worked.

@de-code de-code merged commit 5f022c3 into develop Sep 26, 2019
@de-code de-code deleted the fix-many-client-dep-bumps branch September 26, 2019 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants