Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This will break after React 16.4.0 #121

Closed
gaearon opened this issue May 23, 2018 · 5 comments
Closed

This will break after React 16.4.0 #121

gaearon opened this issue May 23, 2018 · 5 comments

Comments

@gaearon
Copy link

gaearon commented May 23, 2018

We renamed some of the internal top level types in facebook#12629 so the plugin in its current form will break. It's not a semver-major change because this plugin was never supported officially and relies on private APIs that can change in any patch.

@s0meone
Copy link

s0meone commented May 24, 2018

Hi @gaearon, thanks for letting us know. You've already warned for this in #112 so we knew this was coming. We're not planning on supporting >=16.4 and will make this clear in the README. I think it's time to move away from this plugin anyway since the problem has gone away mostly.

@gaearon
Copy link
Author

gaearon commented May 24, 2018

Lol I forgot about that issue, sorry for the spam. Feel free to close :-)

@s0meone
Copy link

s0meone commented May 24, 2018

No worries, thanks for the reminder 😄

You suggested turning this plugin into a <Tappable> component but I feel that would create a bigger migration path than simply replacing onTouchTap to onClick. Since the problem is already solved by most browsers.

I've already experimented with a userland onTouchTap replacement but performance was very poor. The main problem is the name of the handler on the lower case React elements (div, button etc), this has to be replaced with the actual handler before rendering.

So I think it's time to end this plugin.

@konglx90
Copy link

konglx90 commented Jun 1, 2018

Everything will come to an end. Anyway, it works good on my app. Thank you very much!

@pacifio
Copy link

pacifio commented Nov 14, 2018

I am using react 16.0.0 on an old project but it wont work ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants