Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable chokidar polling override in tests #1703

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

chancancode
Copy link
Contributor

Ran into bugs/issues with using polling mode when writing tests for #1696, specifically that on my macOS dev environment using polling, when watching a directory it doesn't seem to consistently emit the added event.

Mainly I wanted to see which, if any, tests fail without this option. It also seemed a bit suspect since rollup/chokidar presumably works on windows out of the box?

Even if this is necessary we may want to limit it to the windows test only (can just set CHOKIDAR_USEPOLLING on the job level), since this makes things less realistic everywhere else.

Ran into bugs/issues with using polling mode when writing tests for embroider-build#1696, specifically that on my macOS dev environment using polling, when watching a directory it doesn't seem to consistently emit the `added` event. 

Mainly I wanted to see which, if any, tests fail without this option. It also seemed a bit suspect since rollup/chokidar presumably works on windows out of the box? 

Even if this is necessary we may want to limit it to the windows test only (can just set `CHOKIDAR_USEPOLLING` on the job level), since this makes things _less_ realistic everywhere else.
@@ -39,11 +39,6 @@ export class DevWatcher {
configFile.options.map((options: RollupOptions) => {
options.watch = {
buildDelay: 20,
// Windows doesn't have a good file-watching mechanism (such as inotify),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rip windows

@NullVoxPopuli NullVoxPopuli merged commit 65ea799 into embroider-build:main Dec 5, 2023
201 checks passed
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
@chancancode chancancode deleted the patch-2 branch December 5, 2023 23:11
void-mAlex added a commit that referenced this pull request Dec 5, 2023
…09862bd7d79d899f55c8fda63

Backport #1703 to stable
@github-actions github-actions bot mentioned this pull request Dec 6, 2023
This was referenced Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants