Failing test for #1696 #1711
Open
Failing test for #1696 #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a bunch of watch-mode (not) rebuilding issues; as a general rule everytime we probe or read from the file system we should at least consider whether such an annotation is needed. Unfortunately this package doesn't appear to be tested currently, but I have applied the same patch locally and it appears to be working fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test works locally (macOS) but doesn't appear to be working in the CI linux/windows environment. I can also reproduce it locally if I revert #1703 and opt for the polling mode. The issue seems to be that the
addevent isn't triggered reliably in the test environment; I suspect this has something to do with how the test is setup, as the feature itself seems to work fine in the actual rollup CLI. Unfortunately I ran out of time to investigate this further so I'm leaving the test here for someone else to look at.