Fix GL.currArrayBuffer and GL.currElementArrayBuffer #11225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
May 26, 2020
…racked as per GL context specific variables and not global process wide variables. Rename the variables to more canonical GL names. Micro-optimize code size of glDeleteBuffers to avoid referencing these variable names unless actually used (FULL_ES2 | LEGACY_GL_EMULATION modes)
juj
force-pushed
the
fix_curArrayBuffer_binding
branch
from
3e75d40
to
29f57ec
Compare
prideout
added a commit
to prideout/emscripten
that referenced
this pull request
Jul 28, 2020
This regressed when some state tracking was renamed and moved on May 26 via PR emscripten-core#11225, and the integer variant of glVertexAttribPointer was overlooked. google/filament#2856
juj
pushed a commit
that referenced
this pull request
Jul 28, 2020
This regressed when some state tracking was renamed and moved on May 26 via PR #11225, and the integer variant of glVertexAttribPointer was overlooked. google/filament#2856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GL.currArrayBuffer and GL.currElementArrayBuffer to be properly tracked as per GL context specific variables and not global process wide variables. Rename the variables to more canonical GL names. Micro-optimize code size of glDeleteBuffers to avoid referencing these variable names unless actually used (FULL_ES2 | LEGACY_GL_EMULATION modes)