Repair broken glVertexAttribIPointer in WebGL 2. #11742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed when some state tracking was renamed and moved on May 26 via PR emscripten-core#11225, and the integer variant of glVertexAttribPointer was overlooked. google/filament#2856
|
Thank you for submitting a pull request! If this is your first PR, make sure to add yourself to AUTHORS. |
|
Really sorry for the regression, thought I would have search-replaced across all files, but apparently not :( Thanks for the fix! |
prideout
added a commit
to google/filament
that referenced
this pull request
Mar 24, 2021
This was put in as a workaround for #2856. I made a fix to emscripten itself (yay open source) in July. So, this workaround is no longer necessary. Verified with the rigged figure model. emscripten-core/emscripten#11742
prideout
added a commit
to google/filament
that referenced
this pull request
Mar 24, 2021
This was put in as a workaround for #2856. I made a fix to emscripten itself (yay open source) in July. So, this workaround is no longer necessary. Verified with the rigged figure model. emscripten-core/emscripten#11742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed when some state tracking was renamed and moved on May 26 via PR #11225, and the integer variant of glVertexAttribPointer was overlooked.
google/filament#2856