Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

size: investigate binary increase in envoy #447

Closed
junr03 opened this issue Sep 17, 2019 · 8 comments
Closed

size: investigate binary increase in envoy #447

junr03 opened this issue Sep 17, 2019 · 8 comments
Assignees
@junr03
Labels
no stalebot perf/size
Milestone
v0.4 "Contorno"

Comments

@junr03
Copy link
Member

junr03 commented Sep 17, 2019

After #388 the binary size increased. We need to investigate what parts of the binary increased.
@junr03 junr03 self-assigned this Sep 17, 2019
@junr03 junr03 mentioned this issue Sep 17, 2019
Merged
@rebello95 rebello95 mentioned this issue Oct 4, 2019
Merged
@stale
Copy link

stale bot commented Oct 17, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 17, 2019
@rebello95 rebello95 added this to the v0.3 "Secondi" milestone Oct 23, 2019
@stale stale bot removed the stale label Oct 23, 2019
@junr03
Copy link
Member Author

junr03 commented Oct 25, 2019

another commit that increased the binary size: #554

@junr03
Copy link
Member Author

junr03 commented Dec 4, 2019

and one more: #607

We will prioritize another pass in size analysis early January.

@junr03 junr03 mentioned this issue Dec 4, 2019
Merged
@junr03
Copy link
Member Author

junr03 commented Jan 13, 2020

and the one that broke the camel's back: #626

@junr03 junr03 mentioned this issue Jan 13, 2020
Merged
junr03 added a commit that referenced this issue Jan 13, 2020
@junr03
envoy: update envoy ref and update config to v3 supported schema (#626)
bceee99 
Description: this PR updates Envoy Mobile's Envoy ref past the point where Envoy internally uses v3 config. I took the chance to update Envoy Mobile's config and delete deprecated fields. Note that SAN verification changes, and thus it was removed here. I opened an issue tracking #630. Further note that this ref update significantly increased the binary size. It is a priority for the team to investigate and trim the binary ahead of the v0.3 release (noted in #447)
Risk Level: med boost to v3 config and deleted deprecated fields.
Testing: passing liveliness in CI and locally.

Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 mentioned this issue Jan 14, 2020
Merged
junr03 added a commit that referenced this issue Jan 15, 2020
@junr03
envoy: update envoy ref (#631)
72efbb7 
Description: updating the envoy ref again and the absolute binary size per #447.
Risk Level: low
Testing: CI

Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03
Copy link
Member Author

junr03 commented Jan 29, 2020

I want to make sure that I run the analysis over everything that we will need for v0.3. Hence it will also include this: #645

@rebello95 rebello95 mentioned this issue Feb 10, 2020
Merged
@rebello95
Copy link
Contributor

Seeing another increase in #663

@rebello95
Copy link
Contributor

Closing this issue in favor of other issues tagged with perf/size and #710

@junr03
Copy link
Member Author

junr03 commented Jul 15, 2020

keeping this issue closed, but noting this #923 pr as a point that should be analyzed as the bump is pretty significant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junr03 junr03

Labels
no stalebot perf/size
Projects
None yet
Milestone
v0.4 "Contorno"
Development

No branches or pull requests
2 participants
@rebello95 @junr03