Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: update upstream for multiple fixes #923

Merged
merged 9 commits into from
Jul 15, 2020
Merged

envoy: update upstream for multiple fixes #923

merged 9 commits into from
Jul 15, 2020

Conversation

goaway
Copy link
Contributor

@goaway goaway commented Jun 21, 2020

Description: Pulls in multiple fixes committed to upstream Envoy.

Signed-off-by: Mike Schore mike.schore@gmail.com

@rebello95
Copy link
Contributor

CI failures are legit

@stale
Copy link

stale bot commented Jun 30, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@goaway
Copy link
Contributor Author

goaway commented Jul 8, 2020

It also looks like there's some upstream Envoy code that has been moved into an extension which we need to forceRegister. Will confirm the stacktrace and update this tomorrow (hopefully my upstream PR will be merged by then as well).

@goaway goaway changed the base branch from master to main July 9, 2020 01:19
@goaway
Copy link
Contributor Author

goaway commented Jul 10, 2020

Now waiting on envoyproxy/envoy#12011 to merge.

Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
@rebello95
Copy link
Contributor

@goaway please update the PR description referencing all the fixes this pulls in like I had in #951

@goaway
Copy link
Contributor Author

goaway commented Jul 15, 2020

sure thing, thanks @rebello95

@goaway goaway changed the title envoy: update for TLSContext fix envoy: update upstream for multiple fixes Jul 15, 2020
@goaway
Copy link
Contributor Author

goaway commented Jul 15, 2020

size_compare is failing, but my intent is to merge if everything else is green. There's not much we can do about it since we do need to be able to update upstream Envoy. We can separately evaluate whether we want to bump this soft limit and/or increase the priority of binary footprint reduction efforts.

@goaway goaway merged commit 17fd64b into main Jul 15, 2020
@goaway goaway deleted the ms/tlscontext branch July 15, 2020 02:49
@junr03
Copy link
Member

junr03 commented Jul 15, 2020

@goaway it would be good to run a test regression analysis to see what happened here. It is one of the biggest bumps I have seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants