Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-run size analysis and create perf/size issues that fall out #983

Closed
junr03 opened this issue Jul 29, 2020 · 3 comments
Closed

re-run size analysis and create perf/size issues that fall out #983

junr03 opened this issue Jul 29, 2020 · 3 comments
Assignees
@junr03
Labels
no stalebot perf/size stale

Comments

@junr03
Copy link
Member

junr03 commented Jul 29, 2020 •
edited
Loading

Two recent PRs increased size significantly: #923 and #981
@junr03 junr03 self-assigned this Jul 29, 2020
junr03 added a commit that referenced this issue Jul 29, 2020
@junr03
update envoy to f958d39fcd (#981)
811235d 
Description: update Envoy to f958d39fcd. Format checker required moving away from std::unordered_map. Additionally, link stamping changed significantly. New bazel targets adapt to the new mechanisms.
Risk level: increase in binary size, need to re-analyze #983 
Testing: CI

Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 mentioned this issue Jul 29, 2020
Merged
@stale
Copy link

stale bot commented Aug 29, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 29, 2020
@stale
Copy link

stale bot commented Sep 29, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 29, 2020
@stale
Copy link

stale bot commented Oct 11, 2020

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junr03 junr03

Labels
no stalebot perf/size stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junr03 @buildbreaker