test: declare hotrestart_test as enormous to hopefully avoid timeouts. #11459
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
|
Something must have changed here. Is this possibly related to @zuercher recent change? I can't imagine the test should take this long? |
|
I tested this. Before @zuercher 's commit, the test was taking 172s (on my dev box). After, it's taking 176s. I did two runs of the test with each build, and they were very consistent. So the change did slightly increase the test time, but not by a lot. It may have pushed it past the timeout in CI though. |
|
As you can see this fails tsan, even declared as |
|
Well, this PR is still timing out for that test in TSAN, so something is definitely broken. :( |
Ah OK, maybe there is a bug/race there also that needs to be fixed? |
|
Do we think this bug might have been introduced by #11357 ? Or was it pre-existing? |
|
No idea. |
| @@ -230,6 +230,7 @@ exports_files(["test_utility.sh"]) | |||
|
|
|||
| envoy_sh_test( | |||
| name = "hotrestart_test", | |||
| size = "enormous", | |||
There was a problem hiding this comment.
We need to fix envoy_sh_test to actual pass this size flag to envoy_cc_test. I'll put up a PR that does both, since I think @jmarantz may already be offline.
There was a problem hiding this comment.
I'll close this in favor of yours.
Commit Message: we gave been seeing timeouts in CI on this test, which I find takes 220 seconds on my workstation. In CI it might take longer, so declare the test enormous and hopefully no timeouts.
Additional Description:
Risk Level: low
Testing: just that test (in asan mode).
Docs Changes: n/a
Release Notes: n/a