test: give hotrestart_test more time to run #11478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit Message: Recent changes to the hot restart test (to use dynamic base id) make it a bit slower and it's hitting the test timeout. Give it more time and fix the bug where we didn't pass additional args to envoy_cc_test. Risk Level: low Testing: fixes tests Doc Changes: n/a Release Notes: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
jmarantz
approved these changes
Jun 5, 2020
mattklein123
approved these changes
Jun 5, 2020
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Recent changes to the hot restart test (to use dynamic base id) make it a bit slower and it's hitting the test timeout. Give it more time and fix the bug where we didn't pass additional args to envoy_cc_test. Risk Level: low Testing: fixes tests Doc Changes: n/a Release Notes: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Recent changes to the hot restart test (to use dynamic base id)
make it a bit slower and it's hitting the test timeout. Give
it more time and fix the bug where we didn't pass additional
args to envoy_cc_test.
Risk Level: low
Testing: fixes tests
Doc Changes: n/a
Release Notes: n/a
Signed-off-by: Stephan Zuercher zuercher@gmail.com