Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds-failover: plumb the API and the mux to the failover #34417

Closed
wants to merge 4 commits into from

generic grpc-mux tests

86d9431
Select commit
Loading
Failed to load commit list.
Closed

xds-failover: plumb the API and the mux to the failover #34417

generic grpc-mux tests
86d9431
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Core succeeded May 30, 2024 in 2m 41s

Mobile/Core (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/Core (pr/34417/main@86d9431)

Check started by

Request (pr/34417/main@86d9431)

adisuissa @adisuissa 86d9431 #34417 merge main@9f4e1f8

xds-failover: plumb the API and the mux to the failover

Commit Message: xds-failover: plumb the API and the mux to the failover
Additional Description:
Plumbing the failover support to the API and the different GrpcMux objects.
The biggest change here is that the GrpcMux objects use the GrpcMuxFailover object instead of the GrpcStream object.
Note that this feature is guarded by envoy.restart_features.xds_failover_support which is false by default, and without setting it to true the GrpcStream will be used directly.
Risk Level: medium - but guarded and false by default.
Testing: Added unit and integration tests.
Docs Changes: N/A - will add once the feature is out of alpha
Release Notes: N/A - will add once the feature is out of alpha

Environment

Request variables

Key Value
ref 71d8097
sha 86d9431
pr 34417
base-sha 9f4e1f8
actor adisuissa @adisuissa
message xds-failover: plumb the API and the mux to the failover...
started 1717097359.715353
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true