Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bazel configuration ambiguity for non HTTP3 builds #34483

Merged
merged 3 commits into from
Jun 6, 2024

Simplified the names of always_{true|false}_flag

88cb8f3
Select commit
Loading
Failed to load commit list.
Merged

Fixed bazel configuration ambiguity for non HTTP3 builds #34483

Simplified the names of always_{true|false}_flag
88cb8f3
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/iOS tests skipped Jun 4, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/34483/main@88cb8f3)

tedjpoole @tedjpoole 88cb8f3 #34483 merge main@b7d61cb

Fixed bazel configuration ambiguity for non HTTP3 builds

To avoid ambiguity when building with //bazel:http3=False (on PPC and Windows) this commit adds 2 new config_setting_groups and updates the relevant select() statements.

Fixes #34482

Environment

Request variables

Key Value
ref 1c183ea
sha 88cb8f3
pr 34483
base-sha b7d61cb
actor tedjpoole @tedjpoole
message Fixed bazel configuration ambiguity for non HTTP3 builds...
started 1717525383.07378
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true
View more details on CI (Envoy)