Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[balsa] Disallow CR not followed by LF in header values. #34829

Merged
merged 5 commits into from
Jun 25, 2024

Merge remote-tracking branch 'upstream/main' into cr

f15b9f2
Select commit
Loading
Failed to load commit list.
Merged

[balsa] Disallow CR not followed by LF in header values. #34829

Merge remote-tracking branch 'upstream/main' into cr
f15b9f2
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/CC succeeded Jun 25, 2024 in 25m 4s

Mobile/CC (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/CC (pr/34829/main@f15b9f2)

Check started by

Request (pr/34829/main@f15b9f2)

bencebeky @bencebeky f15b9f2 #34829 merge main@128a99a

[balsa] Disallow CR not followed by LF in header values.

Commit Message: [balsa] Disallow CR not followed by LF in header values.
Additional Description: This makes the behavior of BalsaParser consistent with that of http-parser.
Risk Level: low
Testing: //test/common/http/http1:codec_impl_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Environment

Request variables

Key Value
ref bb0d0c5
sha f15b9f2
pr 34829
base-sha 128a99a
actor bencebeky @bencebeky
message [balsa] Disallow CR not followed by LF in header values....
started 1719328486.988361
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true