Added utility methods to parse ORCA response headers from backends. #35422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: blake-snyder <blakesnyder@google.com>
|
Hi @blake-snyder, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
/assign @adisuissa |
|
blake-snyder is not allowed to assign users. |
Switch string serialization util method to something compatible with all builds. Signed-off-by: blake-snyder <blakesnyder@google.com>
|
Failed checks appear to be related to cncf/xds#97 |
|
@blake-snyder some error handling code is not covered by tests and coverage requirement is not met. https://storage.googleapis.com/envoy-pr/4dacf1a/coverage/source/common/orca/orca_parser.cc.gcov.html /wait-any |
|
@wbpcode will you have the bandwidth to be the senior-maintainer reviewing the ORCA & new LB policy PRs? |
Signed-off-by: blake-snyder <blakesnyder@google.com>
Signed-off-by: blake-snyder <blakesnyder@google.com>
Signed-off-by: blake-snyder <blakesnyder@google.com>
wbpcode
reviewed
Jul 27, 2024
soulxu
reviewed
Jul 29, 2024
…eaders. Change static constexpr variables to absl::string_view. Signed-off-by: blake-snyder <blakesnyder@google.com>
wbpcode
reviewed
Jul 30, 2024
Signed-off-by: blake-snyder <blakesnyder@google.com>
Signed-off-by: blake-snyder <blakesnyder@google.com>
|
/retest |
wbpcode
reviewed
Aug 7, 2024
Signed-off-by: blake-snyder <blakesnyder@google.com>
Signed-off-by: blake-snyder <blakesnyder@google.com>
wbpcode
approved these changes
Aug 8, 2024
adisuissa
approved these changes
Aug 8, 2024
|
/retest |
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
…nds. (envoyproxy#35422) Signed-off-by: blake-snyder <blakesnyder@google.com> Signed-off-by: asingh-g <abhisinghx@google.com>
This was referenced Aug 27, 2024
Add checks during ORCA header parsing to catch error cases gracefully handled by util method.
#35868
Merged
wbpcode
pushed a commit
that referenced
this pull request
Oct 5, 2024
Commit Message: Add support for multiple formats of ORCA headers. Additional Description: Add support for multiple formats of ORCA headers. ORCA parsing introduced in #35422 [Original Design Proposal](#6614) [Using ORCA load reports in Envoy](https://docs.google.com/document/d/1gb_2pcNnEzTgo1EJ6w1Ol7O-EH-O_Ysu5o215N9MTAg/edit#heading=h.bi4e79pb39fe) Risk Level: Low Testing: See included unit tests. Docs Changes: N/A Release Notes: N/A Platform Specific Features: JSON format unsupported on Mobile. CC @efimki @adisuissa @wbpcode --------- Signed-off-by: blake-snyder <blakesnyder@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add utility methods to parse ORCA response headers from backends.
Additional Description: Add utility methods to parse ORCA response headers from backends.
parseOrcaLoadReportHeaderswill be called from theRouterFilter.Open Request Cost Aggregation (ORCA) Design Proposal
Using ORCA load reports in Envoy
Risk Level: Low
Testing: See included unit tests.
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: JSON formatted header not supported on Envoy Mobile
CC @efimki @AndresGuedez