Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: draining the buffer on close #9870

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

alyssawilk
Copy link
Contributor

Risk Level: Medium (changes the connection class)
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alyssawilk
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mattklein123 mattklein123 merged commit 47f83da into envoyproxy:master Jan 29, 2020
lizan added a commit that referenced this pull request Mar 3, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Jianfei Hu <jianfeih@google.com>
Co-authored-by: Lizan Zhou <lizan@tetrate.io>
howardjohn pushed a commit to istio/envoy that referenced this pull request Mar 3, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Jianfei Hu <jianfeih@google.com>
Co-authored-by: Lizan Zhou <lizan@tetrate.io>
lizan added a commit that referenced this pull request Mar 3, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
PiotrSikora pushed a commit to PiotrSikora/envoy that referenced this pull request Mar 3, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
istio-testing pushed a commit to istio/envoy that referenced this pull request Mar 4, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Co-authored-by: Lizan Zhou <lizan@tetrate.io>
LukeShu pushed a commit to datawire/envoy that referenced this pull request Apr 6, 2020
…) (envoyproxy#124)

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Jianfei Hu <jianfeih@google.com>
Co-authored-by: Lizan Zhou <lizan@tetrate.io>
@alyssawilk alyssawilk deleted the drain_early branch August 27, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants