Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3 use after free #110

Closed
wants to merge 107 commits into from

Conversation

jplevyak
Copy link

@jplevyak jplevyak commented Oct 9, 2019

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

alyssawilk and others added 30 commits August 13, 2019 14:39
…ective chains (envoyproxy#7779)

An (no longer annoyingly one-off) solution to the common problem folks run into with Envoy configs where they add their filters behind the router filter and don't get why things aren't working. Ditto for HCM, tcp_proxy etc for L4

Risk Level: Low (except for folks with broken config)
Testing: new UT
Docs Changes: n/a
Release Notes: n/a
Fixes envoyproxy#7767

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Removes a stale, unimplemented constructor definition.

Risk Level: low
Testing: n/a
Doc Changes: n/a
Release Notes: n/a

Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Set release managers as CODEOWNERS for release-1.3
This is so that Envoy keeps building with the --incompatible_disable_legacy_proto_provider command line option of Bazel which is to be flipped in 1.0 .

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:

Signed-off-by: Lukacs T. Berki <lberki@google.com>
Omit the node identifier from subsequent discovery requests on the same stream.
Restricted to non-incremental xDS for tractability.

Risk Level: low, affects xDS protocol but guarded by an option
Testing: Unit/integration tests are updated
Docs Changes: xDS spec clarification
Release Notes: omit the node identifier from subsequent discovery requests

Fixes: envoyproxy#7860

Signed-off-by: Kuat Yessenov <kuat@google.com>
To be used with delta ADS. Could probably be used with the current GrpcMuxImpl. Has the SubscriptionCallbacks interface, so a GrpcMux can just directly pass onConfigUpdate() calls through to the WatchMap, which will then appropriately distribute the various resources to the various watches' SubscriptionCallbacks. envoyproxy#4991

Risk Level: none, not yet built into Envoy
Testing: unit tests for the new class

Signed-off-by: Fred Douglas <fredlas@google.com>
Merge from envoyproxy/envoy-wasm:master
Description:
In preparation to implement TCP gRPC Access Logger.

Risk Level: Low (refactoring only)
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
…xy#7865)

Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
Signed-off-by: Cynthia Coan <ccoan@instructure.com>
Description:

Upgrade yapf to the latest version. We'd like to reuse it in our local repo, and some of the newer versions contain fixes we need.

This required reformatting all the files for their new rules. Happy to change any rules, as necessary.

Risk Level: Low
Testing: Ensure py format checks can still pass.
Docs Changes: N/A
Release Notes: N/A

fixes envoyproxy#7389

Signed-off-by: Cynthia Coan <ccoan@instructure.com>
* Add trafic direction API.

Signed-off-by: John Plevyak <jplevyak@gmail.com>
Per envoyproxy#7736, we're inadvertently casting a lambda expression to
bool. Fortunately, the code is attempting to pass true, so it
works.

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes: envoyproxy#7736

Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Description: Adds support for DNS SAN as Principal in RBAC filter.
Risk Level: Low
Testing: Added automated tests
Docs Changes: Updated
Release Notes: Added
Fixes envoyproxy#7836

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
…ost weights are equal. (envoyproxy#7877)

Only create EdfScheduler for round-robing and least-request load balancers if hosts have different weights.  This reduces CPU usage during load balancer creation and memory usage in the common case where all hosts have the same weight.

Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
PiotrSikora and others added 17 commits August 26, 2019 15:29
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
…c-1.3

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sync with envoy-wasm/master (2019-08-27).
…oyproxy#7981) (istio#101)

Description: When a request comes in on http1 with "upgrade: h2c", the current behavior is to 503.  Instead we should ignore the upgrade and remove the header and continue with the request as http1.
Risk Level: Medium
Testing: Unit test. Hand test with ithub.com/rdsubhas/java-istio client server locally.
Docs Changes: N/A
Release Notes:  http1: ignore and remove Upgrade: h2c.
Fixes istio/istio#16391

Signed-off-by: John Plevyak <jplevyak@gmail.com>
…uster modification (envoyproxy#8106) (istio#105)

Risk Level: Medium
Testing: New unit test added. Fix verified via --config=asan.

Signed-off-by: Andres Guedez <aguedez@google.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
…stio#189) (istio#107)

* Fix segfault by ensuring that we have created the context in the VM.
envoyproxy/envoy-wasm#180

Signed-off-by: John Plevyak <jplevyak@gmail.com>
* Add Dockerfile for the C++ SDK.

Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Tracking header size and add limit for the number of headers
Also fix flaky RetryHostPredicateFilterTest

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
…ny recursively (envoyproxy#8231) (istio#109)

Use TextFormat::Print with SetExpandAny(true) instead of SerializeAsString to calculate hash with Any expanded.

Risk Level: Med
Testing: CI, regression test

Fixes envoyproxy#5744.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
(cherry picked from commit 647aea1)
Signed-off-by: John Plevyak <jplevyak@gmail.com>
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@jplevyak
Copy link
Author

jplevyak commented Oct 9, 2019

istio/istio#17699

@jplevyak jplevyak closed this Oct 9, 2019
howardjohn pushed a commit that referenced this pull request Mar 3, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Jianfei Hu <jianfeih@google.com>
Co-authored-by: Lizan Zhou <lizan@tetrate.io>
istio-testing pushed a commit that referenced this pull request Mar 4, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Co-authored-by: Lizan Zhou <lizan@tetrate.io>
fpesce pushed a commit that referenced this pull request Jun 30, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
brian-avery pushed a commit that referenced this pull request Jun 30, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Jianfei Hu <jianfeih@google.com>
Co-authored-by: Lizan Zhou <lizan@tetrate.io>
Miss-you pushed a commit to Miss-you/envoy that referenced this pull request Nov 17, 2020
…o-intro

zh translation:/intro/arch_overview/intro/intro.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.