…ective chains (envoyproxy#7779)

An (no longer annoyingly one-off) solution to the common problem folks run into with Envoy configs where they add their filters behind the router filter and don't get why things aren't working. Ditto for HCM, tcp_proxy etc for L4

Risk Level: Low (except for folks with broken config)
Testing: new UT
Docs Changes: n/a
Release Notes: n/a
Fixes envoyproxy#7767

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Removes a stale, unimplemented constructor definition.

Risk Level: low
Testing: n/a
Doc Changes: n/a
Release Notes: n/a

Signed-off-by: Stephan Zuercher <zuercher@gmail.com>

Set release managers as CODEOWNERS for release-1.3

This is so that Envoy keeps building with the --incompatible_disable_legacy_proto_provider command line option of Bazel which is to be flipped in 1.0 .

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:

Signed-off-by: Lukacs T. Berki <lberki@google.com>

Omit the node identifier from subsequent discovery requests on the same stream.
Restricted to non-incremental xDS for tractability.

Risk Level: low, affects xDS protocol but guarded by an option
Testing: Unit/integration tests are updated
Docs Changes: xDS spec clarification
Release Notes: omit the node identifier from subsequent discovery requests

Fixes: envoyproxy#7860

Signed-off-by: Kuat Yessenov <kuat@google.com>

To be used with delta ADS. Could probably be used with the current GrpcMuxImpl. Has the SubscriptionCallbacks interface, so a GrpcMux can just directly pass onConfigUpdate() calls through to the WatchMap, which will then appropriately distribute the various resources to the various watches' SubscriptionCallbacks. envoyproxy#4991

Risk Level: none, not yet built into Envoy
Testing: unit tests for the new class

Signed-off-by: Fred Douglas <fredlas@google.com>

Merge from envoyproxy/envoy-wasm:master

Description:
In preparation to implement TCP gRPC Access Logger.

Risk Level: Low (refactoring only)
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

…nvoyproxy#7851)

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>

…xy#7865)

Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>

Signed-off-by: Xuyang Tao <taoxuy@google.com>

…7904)

Signed-off-by: Alyssa Wilk <alyssar@google.com>

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>

Signed-off-by: Cynthia Coan <ccoan@instructure.com>

Description:

Upgrade yapf to the latest version. We'd like to reuse it in our local repo, and some of the newer versions contain fixes we need.

This required reformatting all the files for their new rules. Happy to change any rules, as necessary.

Risk Level: Low
Testing: Ensure py format checks can still pass.
Docs Changes: N/A
Release Notes: N/A

fixes envoyproxy#7389

Signed-off-by: Cynthia Coan <ccoan@instructure.com>

* Add trafic direction API.

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Per envoyproxy#7736, we're inadvertently casting a lambda expression to
bool. Fortunately, the code is attempting to pass true, so it
works.

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes: envoyproxy#7736

Signed-off-by: Stephan Zuercher <zuercher@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Description: Adds support for DNS SAN as Principal in RBAC filter.
Risk Level: Low
Testing: Added automated tests
Docs Changes: Updated
Release Notes: Added
Fixes envoyproxy#7836

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

…ost weights are equal. (envoyproxy#7877)

Only create EdfScheduler for round-robing and least-request load balancers if hosts have different weights.  This reduces CPU usage during load balancer creation and memory usage in the common case where all hosts have the same weight.

Signed-off-by: Antonio Vicente <avd@google.com>

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>

Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

We pass all environment variables we care about explicitly and should
not pass any other not set variables.

Signed-off-by: Matt Klein <mklein@lyft.com>

Signed-off-by: Asra Ali <asraa@google.com>

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: Henry Yang <hyang@lyft.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Calling out that it's possible to use the value 0 to disable route timeout (as it is for idle timeout).

Signed-off-by: nmeessen <nmeessen@atlassian.com>

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

…lisk (envoyproxy#7934)

Description: Update dependencies:
- rules_go 0.19.2 ([release](https://github.com/bazelbuild/rules_go/releases/tag/0.19.2)), [0.19.0 release notes](https://github.com/bazelbuild/rules_go/releases/tag/0.19.0). The big change is that `org_golang_google_grpc` is no longer declared in `go_rules_dependencies`. In order for the API to build, changes to `WORKSPACE` outlined [here](https://github.com/bazelbuild/rules_go/blob/0.19.0/go/workspace.rst#grpc-dependencies) are required. This pollutes `WORKSPACE` with some dependencies. Open on ways to improve this.
- Go 1.12.8 (to match rules_go)
- various Python updates
- curl 7.65.3 ([changelog](https://curl.haxx.se/changes.html#7_65_3))
- bazel-toolchains switches to 0.28.5 release and address @lizan TODO ([changes](bazelbuild/bazel-toolchains@5a8611e...0.28.5))
- bazelisk 1.0 ([release notes](https://github.com/bazelbuild/bazelisk/releases/tag/v1.0))

Risk Level: Low
Testing: `./docs/build.sh`, `bazel build @envoy_api//envoy/...`, `bazel test //test/...`
Docs Changes: None required
Release Notes: None required

Signed-off-by: Michael Payne <michael@sooper.org>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: Joshua Blatt <jtblatt@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

…xy#7840)

Signed-off-by: Andrew Jenkins <andrew@volunteers.acasi.org>

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>

Add test case for sendLocalResponse

* Do not precoompile for WAVM.

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

…/dynamic config. (envoyproxy#7857)

As per envoyproxy#6651, this PR plumbs in CLI options to allow independent control over static/dynamic unknown
field validation.

The defaults are the same for static as today (strict) and for dynamic we are by default permissive.
This permits easy rollout of new API minor versions, including those related to security fixes.

Fixes a regression that occurred in envoyproxy#7200 where strict/permissive checking CLI options were
inverted.

As per envoyproxy#6818, added stats/warning for any unknown fields encountered.

Risk level: Low (strictly more permissive by default)
Testing: additional unit and integration tests added, exercising both permissive/strict checking
over various parts of the API (bootstrap, listeners, clusters, xDS, network filters, etc).

Fixes envoyproxy#6651
Fixed envoyproxy#6818

Signed-off-by: Harvey Tuch <htuch@google.com>

* Offer a way to opt out of automatic namespacing in prometheus

Signed-off-by: Mandar U Jog <mjog@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Fixes envoyproxy#7927.

Risk Level: low (test only)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Introduces a generic expression-based admission filter using https://github.com/google/cel-cpp.
This is a follow-up to discussion in envoyproxy#6751.
The advantage of this approach is:
1. Un-opinionated about the policy structure since the only config is an expression. This is friendly towards control planes which can bear the complexity of translation, analysis, and evolution of policies.
2. Multi-language, CEL supports go, java, and c++ runtimes.
3. Inter-operability with other filters using request `metadata`. Companion filters can populate metadata about requests and resources that affect policy decisions.
4. Generic utility, it can be used for custom metric labels, access log entries, etc.

The dis-advantage of this approach is that its performance is lower than domain-optimized interpreters. On a fair example, the interpreter evaluates in around 1ms (see https://github.com/google/cel-cpp/blob/master/eval/tests/benchmark_test.cc#L591) vs ~150ns for hand-written C++ native code. There is space for improvement (especially if WASM can be used as a compilation target), but ultimately the generic expression form carries a cost.

Conditions are added to support RBAC filter for complementing the existing principal/permission model. They add support for the extended checks (e.g. time of query, resource-bound), but add no cost unless used.

Description: add expression-based admission filter
Risk Level: low
Testing:
Docs Changes:
Release Notes:

Signed-off-by: Kuat Yessenov <kuat@google.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

* ABI functions return WasmResult.

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: Kuat Yessenov <kuat@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

…envoyproxy#7958)

Description:
libc++ std::string may inline the data which results the memory is not
aligned to `void*`. Use vector instead to store the optval.

Detected by UBSAN with libc++ config. Preparation for envoyproxy#4251

Risk Level: Low
Testing: unittest locally
Docs Changes: N/A
Release Notes: N/A
Fixes envoyproxy#7968

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>

network: fix misaligned memory access in setsockopt().

Add getCurrentTimeNanoseconds wrapper.

Add support for connectionInfo peerCertificatePresented().

Signed-off-by: Mandar U Jog <mjog@google.com>

Merge envoy-wasm into  1.3

…io#143)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

This allows us to start up to 370 VMs.

Fixes istio#136.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

fix upstream host NULL pointer

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: Kuat Yessenov <kuat@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Suggested by Lizan in:
envoyproxy/envoy-wasm#152

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

While there, make build args more readable.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Previously, gInfinity was optimized out because std::isinf(gInfinity)
always evaluates to true, so the global.Infinity variable was never
imported from the host environment.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

…c-1.3

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Sync with envoy-wasm/master (2019-08-27).

…oyproxy#7981) (istio#101)

Description: When a request comes in on http1 with "upgrade: h2c", the current behavior is to 503.  Instead we should ignore the upgrade and remove the header and continue with the request as http1.
Risk Level: Medium
Testing: Unit test. Hand test with ithub.com/rdsubhas/java-istio client server locally.
Docs Changes: N/A
Release Notes:  http1: ignore and remove Upgrade: h2c.
Fixes istio/istio#16391

Signed-off-by: John Plevyak <jplevyak@gmail.com>