Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve display of gatway-api struct #1339

Closed
wants to merge 9 commits into from

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Apr 21, 2023

What type of PR is this?

What this PR does / why we need it:

doc: improve display of gatway-api struct

Which issue(s) this PR fixes:

Fixes #1247

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain requested a review from a team as a code owner April 21, 2023 01:55
@zirain zirain added the documentation Improvements or additions to documentation label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1339 (6417c58) into main (2bf9607) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
+ Coverage   61.79%   61.88%   +0.09%     
==========================================
  Files          76       76              
  Lines       10718    10718              
==========================================
+ Hits         6623     6633      +10     
+ Misses       3648     3640       -8     
+ Partials      447      445       -2     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
Copy link
Contributor Author

zirain commented Apr 21, 2023

/hold

wait elastic/crd-ref-docs#37?

@zirain
Copy link
Contributor Author

zirain commented Apr 24, 2023

replaced by #1348

@zirain zirain closed this Apr 24, 2023
@zirain zirain deleted the api-docs branch July 27, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make crd-ref-docs support gateway-api object
1 participant