Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support KnownTypes #37

Merged
merged 2 commits into from
Apr 24, 2023
Merged

support KnownTypes #37

merged 2 commits into from
Apr 24, 2023

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Apr 3, 2023

support custom link for KnownType

@zirain
support KnownTypes
e8e0513 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@cla-checker-service
Copy link

cla-checker-service bot commented Apr 3, 2023 •
edited
Loading

💚 CLA has been signed

@zirain zirain mentioned this pull request Apr 3, 2023
Closed
@zirain zirain closed this Apr 3, 2023
@zirain zirain reopened this Apr 3, 2023
@zirain zirain closed this Apr 3, 2023
@zirain zirain reopened this Apr 3, 2023
@zirain zirain mentioned this pull request Apr 3, 2023
Merged
@arkodg
Copy link

arkodg commented Apr 3, 2023

ptal @charith-elastic

@zirain
Copy link
Contributor Author

zirain commented Apr 21, 2023

close this because of no response.

@zirain zirain closed this Apr 21, 2023
@thbkrkr
Copy link
Contributor

thbkrkr commented Apr 21, 2023

Hello @zirain, sorry for the silence here. Could you tell us a bit more about your use case requiring custom link support for known type?

@zirain
Copy link
Contributor Author

zirain commented Apr 21, 2023

EG use some types from https://github.com/kubernetes-sigs/gateway-api, with this patch EG can make better link for certificateRef

similar to https://github.com/ahmetb/gen-crd-api-reference-docs/blob/master/example-config.json#L9

@thbkrkr
Copy link
Contributor

thbkrkr commented Apr 21, 2023

If you stil want this, you can reopen.
I think it would be good to show the existence of this feature by updating:

Then it should be good to be merged.

@zirain zirain reopened this Apr 21, 2023
@zirain
Copy link
Contributor Author

zirain commented Apr 21, 2023

thanks @thbkrkr , will update REAME and demo later

@zirain zirain mentioned this pull request Apr 21, 2023
Closed
@thbkrkr
Copy link
Contributor

thbkrkr commented Apr 21, 2023

Cool, I promise I'll try to be more responsive this time.

@zirain
update README config and test
8fe81a6 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain mentioned this pull request Apr 23, 2023
Merged
@zirain
Copy link
Contributor Author

zirain commented Apr 23, 2023

@thbkrkr update, also send another PR about action.

thbkrkr
thbkrkr approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr thbkrkr merged commit 6be6bcc into elastic:master Apr 24, 2023
@zirain zirain deleted the known-type branch April 24, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbkrkr thbkrkr thbkrkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zirain @arkodg @thbkrkr