When a second mock is created for the same class, dispose of the dynamically created subclass for the first mock. #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mically created subclass for the first mock. Previously that first dynamically created subclass was kept around forever, and if accessed somehow (for example by enumerating objc_getClassList) would always raise NSInternalInconsistencyException.
|
Hey. So I had an issue and noticed this as well. When will this PR get into a new version on cocoapods ? |
|
I had planned to wait for the outcome of #339 to include in the next minor release. It's been taken a while, I know. |
|
This PR created a regression, If 2 partial mocks are created with the same underlying Class type, then the first mock stops forwarding @selectors to the real object. p1.name = @"Person 1";
p2.name = @"Person 2";
Person *mock1 = OCMPartialMock(p1);
mock1.name == @"Person 1"
Person *mock2 = OCMPartialMock(p2);
mock2.name == @"Person 2"
mock1.name == nil //😱 |
erikdoe
added a commit
that referenced
this pull request
Oct 12, 2018
|
Could you check whether the fix I just committed works for you? The new tests introduced in this PR still pass, but the class pair is disposed a little later; not when the second mock takes over but when |
This was referenced May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously that first dynamically created subclass was kept around forever,
and if accessed somehow (for example by enumerating objc_getClassList) would
always raise NSInternalInconsistencyException.