-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdctl: Remove V2 API commands #13643
Conversation
2c8d0f7
to
52b1e15
Compare
52b1e15
to
d5f1ea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @ptabor |
d5f1ea9
to
6da1c3a
Compare
Codecov Report
@@ Coverage Diff @@
## main #13643 +/- ##
==========================================
+ Coverage 72.57% 75.05% +2.48%
==========================================
Files 465 444 -21
Lines 37856 36962 -894
==========================================
+ Hits 27475 27743 +268
+ Misses 8596 7405 -1191
- Partials 1785 1814 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
One more comment, we still support v2 discovery in 3.6. Should we keep the V2 commands, and delete them together the clientv2 & v2 discovery in future? |
@serathius Please rebase this PR. I think it's OK to merge this PR for 3.6. The sever side V2 code has already been removed, so there is no reason to keep the V2 commands. If users need the v2 command, then they can get it from the previous releases, such as 3.5 or 3.4. |
6da1c3a
to
d6368a2
Compare
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Part of #12913
cc @ptabor