-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simply etcdutl backup command to cleanup v2 related implementation #13972
Conversation
4724bb1
to
85d191f
Compare
Codecov Report
@@ Coverage Diff @@
## main #13972 +/- ##
==========================================
- Coverage 74.93% 74.76% -0.18%
==========================================
Files 447 447
Lines 37166 37152 -14
==========================================
- Hits 27852 27777 -75
- Misses 7543 7584 +41
- Partials 1771 1791 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7d86b7b
to
34b7ba4
Compare
34b7ba4
to
f4db543
Compare
cc @ptabor |
f4db543
to
73ea77a
Compare
Just rebased this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just consider preserving the flag to give user's an actionable advise.
73ea77a
to
797e5fb
Compare
797e5fb
to
28240cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad there was no --v2 test coverage at all :(
The V2 commands have already been removed in PR 13643 , so we can simplify the the implementation of
etcdutl backup
command.