Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply etcdutl backup command to cleanup v2 related implementation #13972

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Apr 22, 2022

The V2 commands have already been removed in PR 13643 , so we can simplify the the implementation of etcdutl backup command.

@ahrtr ahrtr marked this pull request as draft April 22, 2022 02:30
@ahrtr ahrtr marked this pull request as ready for review April 24, 2022 21:18
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #13972 (9055296) into main (b00bb53) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

❗ Current head 9055296 differs from pull request most recent head 34b7ba4. Consider uploading reports for the commit 34b7ba4 to get more accurate results

@@            Coverage Diff             @@
##             main   #13972      +/-   ##
==========================================
- Coverage   74.93%   74.76%   -0.18%     
==========================================
  Files         447      447              
  Lines       37166    37152      -14     
==========================================
- Hits        27852    27777      -75     
- Misses       7543     7584      +41     
- Partials     1771     1791      +20     
Flag Coverage Δ
all 74.76% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
etcdutl/etcdutl/backup_command.go 10.77% <0.00%> (+0.83%) ⬆️
server/proxy/grpcproxy/register.go 69.76% <0.00%> (-20.94%) ⬇️
client/pkg/v3/fileutil/purge.go 66.03% <0.00%> (-7.55%) ⬇️
client/v3/leasing/util.go 91.66% <0.00%> (-6.67%) ⬇️
client/v3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
raft/rafttest/node.go 95.00% <0.00%> (-5.00%) ⬇️
client/v3/leasing/txn.go 88.09% <0.00%> (-3.18%) ⬇️
server/etcdserver/cluster_util.go 70.35% <0.00%> (-3.17%) ⬇️
server/etcdserver/api/v3rpc/watch.go 84.89% <0.00%> (-3.03%) ⬇️
client/v3/experimental/recipes/key.go 75.34% <0.00%> (-2.74%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00bb53...34b7ba4. Read the comment docs.

@ahrtr ahrtr force-pushed the simplify_etcdctl_backup branch 4 times, most recently from 7d86b7b to 34b7ba4 Compare April 25, 2022 00:24
@serathius
Copy link
Member

cc @ptabor

@ahrtr
Copy link
Member Author

ahrtr commented Apr 25, 2022

Just rebased this PR.

@ahrtr
Copy link
Member Author

ahrtr commented Apr 27, 2022

@ptabor @spzala Could you take a look at this PR?

Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just consider preserving the flag to give user's an actionable advise.

Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad there was no --v2 test coverage at all :(

@ptabor ptabor merged commit e74c72e into etcd-io:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants