Add lazyfs support for arm64 robustness workflow #16392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhbnz
force-pushed
the
add-lazyfs-arm64-support
branch
2 times, most recently
from
04744f5
to
5168890
Compare
jmhbnz
changed the title
jmhbnz
commented
Aug 9, 2023
There was a problem hiding this comment.
Note for reviewers: I initially had this pr set to run robustness nightly jobs on: pull_request for verification. You can find that actions run here https://github.com/etcd-io/etcd/actions/runs/5801718679.
From what I could see it looks like the lazyfs tests were behaving as expected in main-arm64.
jmhbnz
changed the title
ahrtr
approved these changes
Aug 9, 2023
fuweid
reviewed
Aug 9, 2023
Signed-off-by: James Blair <mail@jamesblair.net>
jmhbnz
force-pushed
the
add-lazyfs-arm64-support
branch
from
5168890
to
34c71d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently in #14691 we introduced support for lazyfs for nightly
amd64robustness tests. Witharm64at tier1 we need to ensurearm64nightlies also support lazyfs.This was a little more complicated as our
arm64nightlies run in containers for better isolation on our self hosted runners. In order to mount the lazyfs fuse based filesystem inside a container we need to run a privileged container to ensure the fuse device is passed through and mountable.This pull request is a pre-requisite before wider adoption of containers for etcd workflows can be progressed under #15956.
The good news is once this pull request merges we will be able to combine
robustness-template-arm64.yamlwithrobustness-template.yamland go back down to one workflow template for all robustness workflows.