add existing http health check handler e2e test #16698
Conversation
chaochn47
force-pushed
the
health_check_e2e_test
branch
from
9b6a873
to
8c55ebf
Compare
chaochn47
force-pushed
the
health_check_e2e_test
branch
from
8c55ebf
to
712caf9
Compare
| // verify that auth enabled serializable read must go through mvcc | ||
| // this test case is skipped until https://github.com/etcd-io/etcd/pull/16697 is merged. | ||
| { | ||
| name: "slow buffer write back with auth enabled", |
There was a problem hiding this comment.
This will block opening backend read tx hence serializable check failed.
To simulate real world failure scenario, we need
- write a key value
backendBatchLimitset to 0- inject
beforeCommit - serializable check an existing key to use boltdb tx.
The no. 4th requirement is not ready yet. Hence use the beforeWritebackBuf sleep to simulate stalled disk write.
There was a problem hiding this comment.
This should be a TODO left in code.
|
Ping @ahrtr @serathius, other than the last skipped test case, I think the others should be good to go. |
chaochn47
force-pushed
the
health_check_e2e_test
branch
2 times, most recently
from
94b9348
to
f2e747f
Compare
chaochn47
force-pushed
the
health_check_e2e_test
branch
from
f2e747f
to
30aace3
Compare
|
Ping @serathius @ahrtr /cc @siyuanfoundation since failure injections should be re-usable. |
chaochn47
force-pushed
the
health_check_e2e_test
branch
from
30aace3
to
18b28cb
Compare
|
ping @ahrtr @serathius if this PR is good to merge. @siyuanfoundation and I are working on adding individual checks and test function in this PR can be re-used. |
chaochn47
force-pushed
the
health_check_e2e_test
branch
2 times, most recently
from
072707a
to
125910d
Compare
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
health_check_e2e_test
branch
from
125910d
to
1324f03
Compare
| if cfg.GoFailEnabled && !proc.Failpoints().Enabled() { | ||
| epc.Close() | ||
| t.Skip("please run 'make gofail-enable && make build' before running the test") | ||
| } |
There was a problem hiding this comment.
Nice. It's much better now. Each use case doesn't need to bother to do this check.
Part of #16007
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.