[3.5] Backport e2e tests for livez/readyz. #17083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siyuan Zhang <sizhang@google.com>
siyuanfoundation
force-pushed
the
livez-bp-step3
branch
from
c4bf59b
to
dc79aec
Compare
|
cc @serathius |
serathius
reviewed
Dec 8, 2023
siyuanfoundation
force-pushed
the
livez-bp-step3
branch
2 times, most recently
from
0e226df
to
fab5df2
Compare
serathius
approved these changes
Dec 11, 2023
|
cc @ahrtr |
ahrtr
reviewed
Dec 11, 2023
Makefile
Outdated
| GOFAIL_VERSION = $(shell cd tools/mod && go list -m -f {{.Version}} go.etcd.io/gofail) | ||
| .PHONY: install-gofail | ||
| install-gofail: | ||
| cd tools/mod; go install go.etcd.io/gofail@${GOFAIL_VERSION} |
There was a problem hiding this comment.
Let's backport #17088 as well, in this PR or in a followup PR. Thanks.
ahrtr
approved these changes
Dec 11, 2023
Signed-off-by: Siyuan Zhang <sizhang@google.com>
siyuanfoundation
force-pushed
the
livez-bp-step3
branch
from
fab5df2
to
cb65c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Part of #16007
Followup PR of #17039
Original PR #16698