Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-07-29] Manual Dependency Bump #18384

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.66%. Comparing base (f181ced) to head (e2367c7).
Report is 3 commits behind head on main.

Current head e2367c7 differs from pull request most recent head abaf079

Please upload reports for the commit abaf079 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 419 files with indirect coverage changes

@@            Coverage Diff            @@
##           main   #18384       +/-   ##
=========================================
+ Coverage      0   68.66%   +68.66%     
=========================================
  Files         0      419      +419     
  Lines         0    35435    +35435     
=========================================
+ Hits          0    24330    +24330     
- Misses        0     9686     +9686     
- Partials      0     1419     +1419     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f181ced...abaf079. Read the comment docs.

…0 to 2.21.0

This commit will bump dependency bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.20.0 to 2.21.0 raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@ahrtr
Copy link
Member

ahrtr commented Jul 31, 2024

Thanks @ArkaSaha30 .

Could you please update the second commit's message to contain the exact command you executed?

Update genproto after *.proto change:
* Please rerun genproto.sh after changing *.proto file
* Run ./scripts/genproto.sh

Error encountered:
[0;31mFAIL: 'genproto' FAILED at Wed Jul 31 07:09:08 UTC 2024
make: *** [Makefile:134: verify-genproto] Error 255

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@ArkaSaha30
Copy link
Contributor Author

Thanks @ArkaSaha30 .

Could you please update the second commit's message to contain the exact command you executed?

Yes, I have just added in the command to run and the error encountered in the commit message

@ahrtr
Copy link
Member

ahrtr commented Jul 31, 2024

Thanks @ArkaSaha30 .
Could you please update the second commit's message to contain the exact command you executed?

Yes, I have just added in the command to run and the error encountered in the commit message

Thanks, please also consider to update https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md in a separate PR, thx

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @ArkaSaha30

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ArkaSaha30

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 04fb588 into etcd-io:main Jul 31, 2024
43 checks passed
@ArkaSaha30 ArkaSaha30 deleted the deps_mgmt_29_7_24 branch August 12, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants