-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add genproto
error troubleshoot step for manual bumps
#18431
Conversation
975fd82
to
7b19a4b
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
@@ Coverage Diff @@
## main #18431 +/- ##
=======================================
Coverage ? 68.90%
=======================================
Files ? 420
Lines ? 35475
Branches ? 0
=======================================
Hits ? 24444
Misses ? 9609
Partials ? 1422 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @ArkaSaha30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @ArkaSaha30 - A few lint nitpicks if you have time.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ArkaSaha30, jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit will add the troubleshooting step in case of `genproto` errors while performing manual dependency bumps of `grpc-*` Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com> Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com> Co-authored-by: James Blair <mail@jamesblair.net>
ef6c00f
to
58ec6b2
Compare
This PR will add the troubleshooting step in case of
genproto
errors while manual dependency bumps ofgrpc-*
pacakges.Sample error:
Ref: #18384 (comment)
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.