Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add genproto error troubleshoot step for manual bumps #18431

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

ArkaSaha30
Copy link
Contributor

This PR will add the troubleshooting step in case of genproto errors while manual dependency bumps of grpc-* pacakges.

Sample error:

[0;31mFAIL: 'genproto' FAILED at Wed Jul 31 07:09:08 UTC 2024
make: *** [Makefile:134: verify-genproto] Error 255

Ref: #18384 (comment)

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 41.01796% with 197 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@00a6097). Learn more about missing BASE report.
Report is 177 commits behind head on main.

Current head 81c02cc differs from pull request most recent head 58ec6b2

Please upload reports for the commit 58ec6b2 to get more accurate results.

Files Patch % Lines
client/v3/kubernetes/client.go 0.00% 91 Missing ⚠️
server/embed/config_logging.go 11.11% 23 Missing and 1 partial ⚠️
etcdctl/ctlv3/command/get_command.go 0.00% 18 Missing ⚠️
client/v3/maintenance.go 13.33% 13 Missing ⚠️
server/etcdserver/server.go 70.00% 6 Missing and 3 partials ⚠️
etcdctl/ctlv3/command/snapshot_command.go 0.00% 8 Missing ⚠️
client/v3/auth.go 66.66% 6 Missing ⚠️
client/v3/lease.go 40.00% 6 Missing ⚠️
pkg/cobrautl/help.go 76.47% 4 Missing ⚠️
server/embed/config.go 88.57% 2 Missing and 2 partials ⚠️
... and 7 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files Coverage Δ
client/v3/kv.go 94.44% <100.00%> (ø)
client/v3/txn.go 100.00% <100.00%> (ø)
client/v3/watch.go 93.83% <100.00%> (ø)
pkg/wait/wait_time.go 100.00% <ø> (ø)
server/auth/simple_token.go 88.46% <100.00%> (ø)
server/config/config.go 79.76% <ø> (ø)
server/embed/etcd.go 75.82% <100.00%> (ø)
server/etcdserver/api/v3rpc/health.go 57.69% <100.00%> (ø)
server/storage/mvcc/kvstore.go 90.44% <ø> (ø)
server/storage/mvcc/store.go 84.61% <100.00%> (ø)
... and 17 more
@@           Coverage Diff           @@
##             main   #18431   +/-   ##
=======================================
  Coverage        ?   68.90%           
=======================================
  Files           ?      420           
  Lines           ?    35475           
  Branches        ?        0           
=======================================
  Hits            ?    24444           
  Misses          ?     9609           
  Partials        ?     1422           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a6097...58ec6b2. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @ArkaSaha30

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ArkaSaha30 - A few lint nitpicks if you have time.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,jmhbnz,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This commit will add the troubleshooting step in case of `genproto`
errors while performing manual dependency bumps of `grpc-*`

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com>
Co-authored-by: James Blair <mail@jamesblair.net>
@ahrtr ahrtr merged commit 9fd94de into etcd-io:main Aug 12, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants