TypeError: Cannot use 'in' operator to search for 'chainId' in 12345 when trying to deploy a contract with empty ABI but with constructor args

[kuzdogan]

Ethers Version

6.6.2

Search Terms

"operator to search", "empty abi"

Describe the Problem

I was testing a wrong contract deployment and got this unrelated error Cannot use 'in' operator to search for 'chainId' in 12345. Digging deeper I noticed it is because the abi is empty and the ContractFactory gives a default constructor() when no constructor was found.

Even though an empty abi is not common and this was a test that was meant to be failed on purpose, I still believe the resulting error is not informative and unrelated to what's going on. IMHO a fix to this can be a check on an empty abi.

Happy to open a PR if we think this is the way.

Code Snippet

import { ContractFactory, JsonRpcProvider } from 'ethers';
import Ganache from 'ganache';
const ganacheServer = Ganache.server();
const GANACHE_PORT = 8545;

const abi = [];
const bytecode = "0x60a060405234801561001057600080fd5b506040516103ca0000000000000000000000000000000000000000000000000000000000000001"
const args = ["12345"]


const exampleFunc = async () => {
    await ganacheServer.listen(GANACHE_PORT);
    const localProvider = new JsonRpcProvider(`http://localhost:${GANACHE_PORT}`);
    const signer = await localProvider.getSigner();

    const contractFactory = new ContractFactory(
    abi,
    bytecode,
    signer
  );

  // Will throw
  const deployment = await contractFactory.deploy(...(args || []));
}

exampleFunc()

Contract ABI

No response

Errors

file:///home/runner/ethers-emptyAbi-bug/node_modules/ethers/lib.esm/providers/provider.js:94
        if (!(key in req) || req[key] == null) {
                  ^

TypeError: Cannot use 'in' operator to search for 'chainId' in 12345
    at copyRequest (file:///home/runner/ethers-emptyAbi-bug/node_modules/ethers/lib.esm/providers/provider.js:94:19)
    at copyOverrides (file:///home/runner/ethers-emptyAbi-bug/node_modules/ethers/lib.esm/contract/contract.js:81:23)
    at ContractFactory.getDeployTransaction (file:///home/runner/ethers-emptyAbi-bug/node_modules/ethers/lib.esm/contract/factory.js:60:31)
    at ContractFactory.deploy (file:///home/runner/ethers-emptyAbi-bug/node_modules/ethers/lib.esm/contract/factory.js:78:31)
    at exampleFunc (file:///home/runner/ethers-emptyAbi-bug/index.js:23:44)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node.js v18.12.1

Environment

node.js (v12 or newer)

Environment (Other)

No response

[ricmoo]

I completely agree! Working on a patch to fix this right now. I think the correct error should be that the overrides is an invalid argument.

[ricmoo]

Fixed in v6.6.6.

Thanks! :)