Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control customization part 2 - Allow for separate corner filling and cornerStroke #2933

Merged
merged 25 commits into from
May 4, 2016
Merged

Conversation

asturur
Copy link
Member

@asturur asturur commented May 3, 2016

  • add CornerStrokeColor property
  • default behaviour with transparentCorners does not change ( for people loading json created before or overriding classes with just cornerColor and transparentCorner = true );

@asturur asturur changed the title Control customization part 2 - Allow for separate cornerFill and cornerStroke Control customization part 2 - Allow for separate corner filling and cornerStroke May 3, 2016
@asturur
Copy link
Member Author

asturur commented May 4, 2016

image

@asturur asturur merged commit 0410aae into fabricjs:master May 4, 2016
@taqimustafa
Copy link
Contributor

Is it possible to have the option to change the rotation handle position, The default position is top, but if we want to show it at the bottom of the Object ?

@asturur
Copy link
Member Author

asturur commented Jun 3, 2016

       if (this.hasRotatingPoint) {
         this._drawControl('mtr', ctx, methodName,
           left + width / 2,
           top + height + this.rotatingPointOffset);
       }

you should override the function that has this snippet with another that is same content but with the hasRotatingPoint part changed like i did

@taqimustafa
Copy link
Contributor

taqimustafa commented Jun 5, 2016

Also can we make the borders dashed ? something similar to the attached image ? This control has dashed line of 2 colors ( black & white )

screenshot_35

@taqimustafa
Copy link
Contributor

i found a way by adding ctx.setLineDash([3,2]); in drawBorders function, but i was hoping if there is anyway we can do that directly ?

@asturur
Copy link
Member Author

asturur commented Jun 6, 2016

http://fabricjs.com/fabric-changelog

check borderDashArray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants