This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Get Buck working for 3.10 #2696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D35971712 |
lisroach
added a commit
to lisroach/buck
that referenced
this pull request
Apr 27, 2022
Summary: Pull Request resolved: facebook#2696 On 3.10 some `collections` classes have been moved to `collections.abc` and it causes Buck 1 to crash. This diff fixes those instances. Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex. fbshipit-source-id: cadb6e533c94b87d38b75d4b9ffcb3d018ffe29a
lisroach
force-pushed
the
export-D35971712-to-dev
branch
from
a87b76c
to
ab32e93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35971712 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D35971712 |
lisroach
added a commit
to lisroach/buck
that referenced
this pull request
Apr 28, 2022
Summary: Pull Request resolved: facebook#2696 On 3.10 some `collections` classes have been moved to `collections.abc` and it causes Buck 1 to crash. This diff fixes those instances. Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex. fbshipit-source-id: daca9d9d35fbb92a9faebca2890d5e2cf78dd67b
lisroach
force-pushed
the
export-D35971712-to-dev
branch
from
ab32e93
to
b20a153
Compare
bigfootjon
approved these changes
Apr 30, 2022
There was a problem hiding this comment.
For some reason the dev branch (synced from Meta) won't build for me, so I cherry-picked this PR onto main and built that.
It works for me! I can now buck run my python3.10-only program!
I'll approve the linked Diff on Monday/after you publish it. Thanks for fixing this!
Summary: Pull Request resolved: facebook#2696 On 3.10 some `collections` classes have been moved to `collections.abc` and it causes Buck 1 to crash. This diff fixes those instances. Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex. Reviewed By: bigfootjon fbshipit-source-id: 1c124b6a7eb7609533555e0d3ad94e7d0fa68d6f
|
This pull request was exported from Phabricator. Differential Revision: D35971712 |
lisroach
force-pushed
the
export-D35971712-to-dev
branch
from
b20a153
to
ab9ded1
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
May 3, 2022
Summary: Pull Request resolved: #2696 On 3.10 some `collections` classes have been moved to `collections.abc` and it causes Buck 1 to crash. This diff fixes those instances. Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex. Reviewed By: bigfootjon fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f
bigfootjon
pushed a commit
that referenced
this pull request
May 4, 2022
Cherry-picked from 1ae1e6c Summary: Pull Request resolved: #2696 On 3.10 some `collections` classes have been moved to `collections.abc` and it causes Buck 1 to crash. This diff fixes those instances. Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex. Reviewed By: bigfootjon fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f
bigfootjon
added a commit
that referenced
this pull request
May 5, 2022
Cherry-picked from 1ae1e6c Summary: Pull Request resolved: #2696 On 3.10 some `collections` classes have been moved to `collections.abc` and it causes Buck 1 to crash. This diff fixes those instances. Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex. Reviewed By: bigfootjon fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f Co-authored-by: Lisa Roach <lisroach@fb.com>
shepting
pushed a commit
to airbnb/buck
that referenced
this pull request
Aug 23, 2022
Cherry-picked from facebook@1ae1e6c Summary: Pull Request resolved: facebook#2696 On 3.10 some `collections` classes have been moved to `collections.abc` and it causes Buck 1 to crash. This diff fixes those instances. Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex. Reviewed By: bigfootjon fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f Co-authored-by: Lisa Roach <lisroach@fb.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
On 3.10 some
collectionsclasses have been moved tocollections.abcand it causes Buck 1 to crash. This diff fixes thoseinstances.
Really pex should be upgraded, but I made an attempt and it was very difficult
due to our custom changes to pex.
Fixes: #2678