This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Get Buck working for 3.10 (backport to main) #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from 1ae1e6c Summary: Pull Request resolved: #2696 On 3.10 some `collections` classes have been moved to `collections.abc` and it causes Buck 1 to crash. This diff fixes those instances. Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex. Reviewed By: bigfootjon fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f
bigfootjon
changed the title
lisroach
approved these changes
May 5, 2022
shepting
pushed a commit
to airbnb/buck
that referenced
this pull request
Aug 23, 2022
Cherry-picked from facebook@1ae1e6c Summary: Pull Request resolved: facebook#2696 On 3.10 some `collections` classes have been moved to `collections.abc` and it causes Buck 1 to crash. This diff fixes those instances. Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex. Reviewed By: bigfootjon fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f Co-authored-by: Lisa Roach <lisroach@fb.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from 1ae1e6c (#2696)
Fixes: #2678
Test plan:
I ran
buckfor a personal project that uses py3.10 syntax (Foo | None) and it was able to build and run correctlyOriginal commit message:
On 3.10 some
collectionsclasses have been moved tocollections.abcand it causes Buck 1 to crash. This diff fixes thoseinstances.
Really pex should be upgraded, but I made an attempt and it was very difficult
due to our custom changes to pex.
Reviewed By: bigfootjon
fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f