docs: add missing Android Permissions to respective releases #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-native ready! 🔨 Explore the source changes: e46e9df 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/616955c88d04180008cfdef9 😎 Browse the preview: https://deploy-preview-2816--react-native.netlify.app |
Simek
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Hi @iBotPeaches, thank you for the update on this and great description of the context of changes! 🙏
Everything looks good to me! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I diffed the permissions in the docs compared to the code and found a few things different.
ACCESS_BACKGROUND_LOCATIONwas added in v62 and never in docs - add ACCESS_BACKGROUND_LOCATION to PermissionsAndroid react-native#26562 - so added to v62 and pushed forwardBLUETOOTH_[CONNECT/SCAN/ADVERTISE]was added in v66 and never in docs (I did those PRs, so this is my fault) - feat: add Android 12 BLUETOOTH_[CONNECT/SCAN] to PermissionsAndroid react-native#31488 and feat: add Android 12 BLUETOOTH_ADVERTISE to PermissionsAndroid react-native#32079ACCESS_MEDIA_LOCATIONis actually a pretty old dangerous permission that was just noticed missing so a PR was already merged into master, so I only targeted it for next release - AddACCESS_MEDIA_LOCATIONpermission react-native#32282I might now audit the actual list of dangerous permissions on AOSP to see if any others are missing.