Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACCESS_MEDIA_LOCATION permission #32282

Closed

Conversation

Skrilltrax
Copy link
Contributor

@Skrilltrax Skrilltrax commented Sep 28, 2021

Summary

This PR adds ACCESS_MEDIA_LOCATION permission to the PermissionsAndroid library. It fixes #31953.

It's a dangerous permission added in API level 29.

https://developer.android.com/reference/android/Manifest.permission#ACCESS_MEDIA_LOCATION

Changelog

[Android] [Added] - Add ACCESS_MEDIA_LOCATION permission to PermisionsAndroid library.

Test Plan

PermissionsAndroid.ACCESS_MEDIA_LOCATION === 'android.permission.ACCESS_MEDIA_LOCATION'

@facebook-github-bot
Copy link
Contributor

Hi @Skrilltrax!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 3516090

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,709,469 +0
android hermes armeabi-v7a 7,239,454 +0
android hermes x86 8,129,931 +0
android hermes x86_64 8,095,131 +0
android jsc arm64-v8a 9,628,978 +0
android jsc armeabi-v7a 8,546,491 +0
android jsc x86 9,643,724 +0
android jsc x86_64 10,252,620 +0

Base commit: 3516090

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 28, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 28, 2021
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

Thanks for the PR @Skrilltrax. I've imported the PR, I believe we should be good merging this 👍

@react-native-bot react-native-bot added Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Oct 1, 2021
@cortinico
Copy link
Contributor

Thanks for the PR @Skrilltrax. I've imported the PR, I believe we should be good merging this 👍

Sorry but this is taking a bit longer than usual. We had some failures on the internal CI that prevented this form landing. We should be good to go. I'll be back next week worst case and will merge this by then.

@Skrilltrax
Copy link
Contributor Author

Thanks for the PR @Skrilltrax. I've imported the PR, I believe we should be good merging this +1

Sorry but this is taking a bit longer than usual. We had some failures on the internal CI that prevented this form landing. We should be good to go. I'll be back next week worst case and will merge this by then.

Hey, no issues. Thanks for the update 👍

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Skrilltrax in 79db483.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PermissionsAndroid.PERMISSIONS.ACCESS_MEDIA_LOCATION isn't implemented yet?
5 participants