Skip to content

Commit

Permalink
Reduce visibility of ReactHost.destroy() method (#37693)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #37693

This diff reduces the visibility of ReactHost.destroy() method

changelog: [internal] internal

Reviewed By: philIip, luluwu2032

Differential Revision: D46293388

fbshipit-source-id: bcc1a8b04517aa0de581b49a14ea2db8b200c3be
  • Loading branch information
mdvacca committed Jun 6, 2023
1 parent c313462 commit 2e57f69
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1209,12 +1209,12 @@ private Task<ReactInstance> new_getOrCreateReloadTask(String reason) {
* Entrypoint to destroy the ReactInstance. If the ReactInstance is reloading, will wait until
* reload is finished, before destroying.
*
* @param reason {@link String} describing why ReactHost is being destroyed (e.g. memmory
* pressure)
* @param ex {@link Exception} exception that caused the trigger to destroy ReactHost (or null)
* This exception will be used to log properly the cause of destroy operation.
* @return A task that completes when React Native gets destroyed.
*/
public Task<Void> destroy(String reason) {
return destroy(reason, null);
}

public Task<Void> destroy(String reason, @Nullable Exception ex) {
final String method = "destroy()";
if (ReactFeatureFlags.enableBridgelessArchitectureNewCreateReloadDestroy) {
Expand Down

0 comments on commit 2e57f69

Please sign in to comment.