Reduce visibility of ReactHost.destroy() method #37693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46293388 |
Base commit: 396cdac |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jun 6, 2023
Summary: Pull Request resolved: facebook#37693 This diff reduces the visibility of ReactHost.destroy() method changelog: [internal] internal Reviewed By: philIip, luluwu2032 Differential Revision: D46293388 fbshipit-source-id: addbe19e0403aadc4f5d7492cce7fc2adb753b99
|
This pull request was exported from Phabricator. Differential Revision: D46293388 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jun 6, 2023
Summary: Pull Request resolved: facebook#37693 This diff reduces the visibility of ReactHost.destroy() method changelog: [internal] internal Reviewed By: philIip, luluwu2032 Differential Revision: D46293388 fbshipit-source-id: cbf80b3da89bf2be0d48636b56e1257fe77534dd
|
This pull request was exported from Phabricator. Differential Revision: D46293388 |
…tHost API Summary: This diff introduces the new generic class BoltsFutureTask<> that will be used by ReactHost to expose async task in its API. The goal of BoltsFutureTask is to avoid leadking the bolts.Task dependency into the ReactHost API. Public methods of this class follow the spec defined in the Future interface, see: https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/Future.html. I didn't add javadocs to avoid duplicated documentation with Future and also becuase this is private class. changelog: [internal] internal Differential Revision: D46170466 fbshipit-source-id: 4500384a6bab227caab570977040528955b5beab
Summary: In this diff I'm reducing visibility of RCTDeviceEventEmitter interface in ReactContext. This is an internal interface that has no usages externally (neither at Meta or github source) changelog: [internal] internal Differential Revision: D46241623 fbshipit-source-id: 9abef4be32f4570e7ed96ae55b3a881ad5c618d8
Summary: Pull Request resolved: facebook#37693 This diff reduces the visibility of ReactHost.destroy() method changelog: [internal] internal Reviewed By: philIip, luluwu2032 Differential Revision: D46293388 fbshipit-source-id: bcc1a8b04517aa0de581b49a14ea2db8b200c3be
|
This pull request was exported from Phabricator. Differential Revision: D46293388 |
|
This pull request has been merged in 57e79fa. |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Jun 8, 2023
* main: (1824 commits) Convert FallbackJSBundleLoaderTest to Kotlin (facebook#37750) Migrate JSPackagerClientTest to Kotlin (facebook#37747) (refactor): kotlin-ify `ShareModuleTest.java` (facebook#37746) Upgrade `@react-native/codegen-typescript-test`'s Jest dependency to Jest 29 (facebook#37745) Move flow-typed definitions to repo root (facebook#37636) Convert InterpolatorTypeTest to Kotlin (facebook#37724) Update documentation of ReactHost.reload method (facebook#37691) Reduce visibility of ReactHost.destroy() method (facebook#37693) Reduce visibility in React Context (facebook#37695) Remove InstanceHandleHelper as unused (facebook#37740) Convert CompositeReactPackageTest to Kotlin (facebook#37734) Add license header to SetSpanOperation.java Convert FakeEventDispatcher to kotlin (facebook#37739) Convert FakeRCTEventEmitter to Kotlin (facebook#37733) Convert InteropModuleRegistryTest to Kotlin (facebook#37735) Bump `autorebase.yml` to `v1.8` (facebook#37584) Convert StackTraceHelperTest to Kotlin (facebook#37741) Convert BlobModuleTest class to Kotlin (facebook#37719) Update prettier to v2.8.8 (facebook#37738) Introduce BoltsFutureTask class to avoid leaking bolts.Task into ReactHost API (facebook#37744) ... # Conflicts: # BUCK # packages/react-native/React/Views/UIResponder+FirstResponder.h # packages/react-native/React/Views/UIResponder+FirstResponder.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff reduces the visibility of ReactHost.destroy() method
changelog: [internal] internal
Reviewed By: luluwu2032
Differential Revision: D46293388