Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert InteropModuleRegistryTest to Kotlin #37735

Closed
wants to merge 1 commit into from

Conversation

dcangulo
Copy link
Contributor

@dcangulo dcangulo commented Jun 6, 2023

Summary:

Converts InteropModuleRegistryTest from Java to Kotlin, as per issue #37708

Changelog:

[Internal] [Changed] - Convert InteropModuleRegistryTest to Kotlin

Test Plan:

Tests pass: ./gradlew :packages:react-native:ReactAndroid:test
Formatted with KtFmt

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2023
@facebook-github-bot
Copy link
Contributor

@mdvacca has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Pranav-yadav Pranav-yadav added the Tests This PR adds or edits a test case. label Jun 7, 2023
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for sending this over @dcangulo

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,744,370 -52
android hermes armeabi-v7a 8,056,580 -47
android hermes x86 9,235,500 -48
android hermes x86_64 9,086,318 -63
android jsc arm64-v8a 9,306,972 -292
android jsc armeabi-v7a 8,496,504 -306
android jsc x86 9,368,975 -308
android jsc x86_64 9,623,889 -314

Base commit: 08dc0a6
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 7, 2023
@facebook-github-bot
Copy link
Contributor

@mdvacca merged this pull request in ecfbabf.

adamaveray added a commit to adamaveray/react-native that referenced this pull request Jun 8, 2023
* main: (1824 commits)
  Convert FallbackJSBundleLoaderTest to Kotlin (facebook#37750)
  Migrate JSPackagerClientTest to Kotlin (facebook#37747)
  (refactor): kotlin-ify `ShareModuleTest.java` (facebook#37746)
  Upgrade `@react-native/codegen-typescript-test`'s Jest dependency to Jest 29 (facebook#37745)
  Move flow-typed definitions to repo root (facebook#37636)
  Convert InterpolatorTypeTest to Kotlin (facebook#37724)
  Update documentation of ReactHost.reload method (facebook#37691)
  Reduce visibility of ReactHost.destroy() method (facebook#37693)
  Reduce visibility in React Context (facebook#37695)
  Remove InstanceHandleHelper as unused (facebook#37740)
  Convert CompositeReactPackageTest to Kotlin (facebook#37734)
  Add license header to SetSpanOperation.java
  Convert FakeEventDispatcher to kotlin (facebook#37739)
  Convert FakeRCTEventEmitter to Kotlin (facebook#37733)
  Convert InteropModuleRegistryTest to Kotlin (facebook#37735)
  Bump `autorebase.yml` to `v1.8` (facebook#37584)
  Convert StackTraceHelperTest to Kotlin (facebook#37741)
  Convert BlobModuleTest class to Kotlin (facebook#37719)
  Update prettier to v2.8.8 (facebook#37738)
  Introduce BoltsFutureTask class to avoid leaking bolts.Task into ReactHost API (facebook#37744)
  ...

# Conflicts:
#	BUCK
#	packages/react-native/React/Views/UIResponder+FirstResponder.h
#	packages/react-native/React/Views/UIResponder+FirstResponder.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tests This PR adds or edits a test case.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants