☂️ Help us Kotlin-ify React Native tests #37708

mdvacca · 2023-06-05T22:59:34Z

Description

Hey all 👋
We're looking for some community support to help us prepare the codebase of React Native Android to be ready to migrate to Kotlin. In this first stage we are looking for help to migrate tests to Kotlin

How to migrate a test

If you wish to convert one of the tests you should:

Verify that the test is not claimed yet.
Comment here that you claim a test.
Start working on adding Kotlin support for the test.
- Make sure your environment is set up correctly (see below)
- Use this PR as inspiration: Convert RootViewTest to Kotlin - #37227
- Make sure the test run correctly (see below).
- Your Kotlin code should be formatted with ktfmt (see below).
Send the PR for review. Ping @cortinico and @mdvacca for a review.

Setting up your environment

Make sure your environment is set correctly, specifically you need to:

Fork react-native
Clone react-native locally
Run yarn inside your local fork (installation instruction for yarn are here)
Make sure you have Java 11 installed and the Android SDK configured (you can follow our official guide here)

Running your tests

You can run your tests either by using the Android Studio/IntelliJ UI or by invoking the following command in your React Native fork:

./gradlew :packages:react-native:ReactAndroid:test

Code formatting

Please use KtFmt to format Kotlin tests.
You can use the web UI to reformat directly from the browser:
https://facebook.github.io/ktfmt/

List of tests to migrate

The text was updated successfully, but these errors were encountered:

ankit-tailor · 2023-06-06T08:55:09Z

Hey @cortinico, Please assign me react/animated/NativeAnimatedNodeTraversalTest.java.

cortinico · 2023-06-06T09:00:02Z

Hey @cortinico, Please assign me react/animated/NativeAnimatedNodeTraversalTest.java.

Done 👍

okwasniewski · 2023-06-06T09:06:29Z

Hey @cortinico, you can assign me to react/modules/deviceinfo/DeviceInfoModuleTest.java

hurali97 · 2023-06-06T09:13:03Z

Hey @cortinico , can you assign me react/modules/clipboard/ClipboardModuleTest.java ?

MohamedRejeb · 2023-06-06T09:17:28Z

Hey @cortinico , can you assign me react/fabric/events/TouchEventDispatchTest.java

fabioh8010 · 2023-06-06T09:17:47Z

Hey @cortinico, can you assign me to this one react/animated/NativeAnimatedInterpolationTest.java?

aymane-missouri-nw · 2023-06-06T09:30:40Z

hey @cortinico , can you assign me to this one react/util/JSStackTraceTest.java

rozkminiacz · 2023-06-06T09:36:09Z

Hi @cortinico , you can assign me to
react/bridge/JavaOnlyArrayTest.java
react/bridge/JavaScriptModuleRegistryTest.java

TheMissouri · 2023-06-06T10:20:24Z

Hey @cortinico , can you assign me to this one react/modules/network/HeaderUtilTest.java

siddarthkay · 2023-06-06T10:25:06Z

Hey @cortinico , I'd like to take this one /react/modules/share/ShareModuleTest.java
please assign it to me

mateusz1913 · 2023-06-06T11:13:00Z

Hey @cortinico, assign me to react/modules/blob/BlobModuleTest.java

tarunrajput · 2023-06-06T11:17:05Z

Hi @cortinico, I'd like to work on this one : react/fabric/interop/FakeEventDispatcher.java

pk-218 · 2023-06-06T11:26:54Z

Hi @cortinico, can you assign react/modules/network/ReactCookieJarContainerTest.java to me?

megatunger · 2023-06-06T11:52:07Z

Hi @cortinico, can you assign this one to me? react/modules/camera/ImageStoreManagerTest.java

cortinico · 2023-06-06T12:14:16Z

Awesome stuff, I've assigned all the tasks that got claimed so far. Folks that got a test class assigned, can start working on it.

RyanGst · 2023-06-06T12:30:17Z

hey @cortinico, can you assign this one to me? react/modules/network/ProgressiveStringDecoderTest.java

fathonyfath · 2023-06-06T13:32:17Z

hey @cortinico , could you assign me this one react/modules/dialog/DialogModuleTest.java

I'll try to help as much as possible :)

jasokolowska · 2023-06-06T14:33:26Z

Hey @cortinico, please assign me react/fabric/interop/InteropEventEmitterTest.java

Summary: This PR converts DialogModuleTest into Kotlin as requested in [this issue](#37708). ## Changelog:  [INTERNAL] [CHANGED] - Convert DialogModuleTest to Kotlin Pull Request resolved: #37795 Test Plan: 1. Run `./gradlew :packages:react-native:ReactAndroid:test`. 2. All tests should pass. Reviewed By: cortinico Differential Revision: D46596235 Pulled By: mdvacca fbshipit-source-id: ef4184664ad885ebd2e8c1d51ca5bb7dc48f0610

Summary: This PR converts DeviceInfoModuleTest into Kotlin as requested in #37708. ## Changelog: [INTERNAL] [CHANGED] - Convert DeviceInfoModuleTest to Kotlin Pull Request resolved: #37805 Test Plan: 1. Run `./gradlew :packages:react-native:ReactAndroid:test`. 2. All tests should pass. Reviewed By: cortinico Differential Revision: D46614375 Pulled By: rshest fbshipit-source-id: 3fc390069628e3ce188121f3e775b28e88875af8

Summary: This PR converts HeaderUtilTest.java to Kotlin as requested in #37708. ## Changelog: [INTERNAL] [CHANGED] - Convert HeaderUtilTest to Kotlin Pull Request resolved: #37829 Test Plan: Run ./gradlew :packages:react-native:ReactAndroid:test. All tests should pass. Reviewed By: mdvacca Differential Revision: D46647152 Pulled By: cortinico fbshipit-source-id: a05108c4cae28526ac55f4f273673221e3ff4cf1

Summary: Part of #37708 ## Changelog: [Internal] [Changed] - Convert JavaOnlyArrayTest to Kotlin Pull Request resolved: #37855 Reviewed By: cortinico Differential Revision: D46697501 Pulled By: rshest fbshipit-source-id: edc3906c41af4936eacdeb95502cc62f80ae89c8

Summary: This PR migrates ReactCookieJarContainerTest.java to Kotlin as a part of the issue #37708 ## Changelog: [INTERNAL] [CHANGED] - Migrate ReactCookieJarContainerTest.java to Kotlin <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #37809 Test Plan: 1. Run ./gradlew :packages:react-native:ReactAndroid:test. 2. All tests should pass. Reviewed By: javache Differential Revision: D46779169 Pulled By: rshest fbshipit-source-id: b5caa9397ac1b852fc73d9c58afc4a21caeb8727

Summary: This PR converts [NativeAnimatedNodeTraversalTest](https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/animated/NativeAnimatedNodeTraversalTest.java) into Kotlin as requested in #37708 ## Changelog: [INTERNAL] [CHANGED] - Convert `NativeAnimatedNodeTraversalTest` to Kotlin Pull Request resolved: #37960 Test Plan: 1. Run `./gradlew :packages:react-native:ReactAndroid:test`. 2. All tests should pass. Reviewed By: javache Differential Revision: D46838215 Pulled By: rshest fbshipit-source-id: 6681d74896a0c94fa7f3ad2ce79eeab4974c55f4

stanwolverine · 2023-06-21T21:13:56Z

@mdvacca Any pending test for me?

mdvacca · 2023-06-22T14:49:27Z

@stanwolverine, let me review the list and I will get back to you

ankit-tailor · 2023-06-22T14:53:20Z

Hey @mdvacca, NativeAnimatedNodeTraversalTest is already migrated.

mdvacca · 2023-06-22T15:06:11Z

@rozkminiacz, @jasokolowska, are you working on:

otherwise, we can reassign them to @stanwolverine

mdvacca · 2023-06-23T17:30:57Z

@stanwolverine I reassigned both tests to you:

stanwolverine · 2023-06-23T18:35:45Z

@mdvacca thanks, I will start working

rupam-seal · 2023-06-28T18:28:08Z

@mdvacca, do you have any test for me?

cortinico · 2023-06-29T08:59:25Z

@mdvacca, do you have any test for me?

Currently all the tests are assigned. If @stanwolverine doesn't send both PRs by the end of tomorrow, we can assign those tests to you @rupam-seal

rupam-seal · 2023-06-29T09:12:32Z

Ok Thank you!🫡

stanwolverine · 2023-06-29T22:21:29Z

Hey @cortinico and @rupam-seal , After solving many issues while setting up react-native on my local machine, I was able to finish both tests. I will send both PRs before the end of tomorrow.

Summary: Helping in [Kotlin-ify React Native tests](#37708), Converted [react/fabric/interop/InteropEventEmitterTest.java](https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/interop/InteropEventEmitterTest.java) to kotlin file ## Changelog:  [INTERNAL] [CHANGED] - `InteropEventEmitterTest.java` file migrated from java to kotlin Pull Request resolved: #38144 Test Plan: Tests should pass ``` ./gradlew :packages:react-native:ReactAndroid:test ``` Reviewed By: NickGerleman Differential Revision: D47165007 Pulled By: mdvacca fbshipit-source-id: 459b0867810eb1b782eea354d74152306b9546ff

Summary: Helping in [Kotlin-ify React Native tests](#37708), Converted [react/bridge/JavaScriptModuleRegistryTest.java](https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/JavaScriptModuleRegistryTest.java) to kotlin file ## Changelog:  [INTERNAL] [CHANGED] - `JavaScriptModuleRegistryTest.java` file migrated from java to kotlin Pull Request resolved: #38143 Test Plan: Tests should pass ``` ./gradlew :packages:react-native:ReactAndroid:test ``` Reviewed By: NickGerleman Differential Revision: D47164993 Pulled By: mdvacca fbshipit-source-id: 6aee2bcb2766fc2e6d68f4df272aaafb9c65bdcb

mdvacca · 2023-07-03T18:58:09Z

Thanks everyone for contributing to migrate React Native Android tests to Kotlin

Since all the tests on the list were migrated, I'm closing this issue!

mdvacca added the Needs: Triage 🔍 label Jun 5, 2023

github-actions bot added Needs: Version Info Needs: Author Feedback and removed Needs: Triage 🔍 labels Jun 5, 2023

facebook deleted a comment from github-actions bot Jun 6, 2023

cortinico added ☂️ Umbrella To label issues that serve as coordination point and drivers for tasks in the react-native repo and removed Needs: Author Feedback Needs: Version Info labels Jun 6, 2023

cortinico pinned this issue Jun 6, 2023

cortinico added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted Issues ideal for external contributors. labels Jun 6, 2023

mateusz1913 mentioned this issue Jun 6, 2023

Convert BlobModuleTest class to Kotlin #37719

Closed

okwasniewski mentioned this issue Jun 9, 2023

Convert DeviceInfoModuleTest to Kotlin #37805

Closed

pk-218 mentioned this issue Jun 9, 2023

re: migrate ReactCookieJarContainerTest to Kotlin #37809

Closed

TheMissouri mentioned this issue Jun 12, 2023

convert HeaderUtilTest to kotlin #37829

Closed

rozkminiacz mentioned this issue Jun 13, 2023

Convert JavaOnlyArrayTest to Kotlin #37855

Closed

This was referenced Jun 19, 2023

refactor: conveted NativeAnimatedInterpolationTest to kotlin #37959

Closed

refactor: converted NativeAnimatedNodeTraversalTest to kotlin #37960

Closed

This was referenced Jun 30, 2023

converted JavaScriptModuleRegistryTest java file to kotlin #38143

Closed

converted InteropEventEmitter java file to kotlin #38144

Closed

mdvacca closed this as completed Jul 3, 2023

kelset unpinned this issue Jul 10, 2023

mdvacca mentioned this issue Aug 7, 2023

☂️ Help us Kotlin-ify React Native tests - Round 2 #38825

Closed

27 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

☂️ Help us Kotlin-ify React Native tests #37708

☂️ Help us Kotlin-ify React Native tests #37708

mdvacca commented Jun 5, 2023 •

edited

Loading

ankit-tailor commented Jun 6, 2023

cortinico commented Jun 6, 2023

okwasniewski commented Jun 6, 2023

hurali97 commented Jun 6, 2023

MohamedRejeb commented Jun 6, 2023 •

edited

Loading

fabioh8010 commented Jun 6, 2023

aymane-missouri-nw commented Jun 6, 2023

rozkminiacz commented Jun 6, 2023

TheMissouri commented Jun 6, 2023

siddarthkay commented Jun 6, 2023 •

edited

Loading

mateusz1913 commented Jun 6, 2023

tarunrajput commented Jun 6, 2023

pk-218 commented Jun 6, 2023

megatunger commented Jun 6, 2023

cortinico commented Jun 6, 2023

RyanGst commented Jun 6, 2023

fathonyfath commented Jun 6, 2023

jasokolowska commented Jun 6, 2023

stanwolverine commented Jun 21, 2023

mdvacca commented Jun 22, 2023 •

edited

Loading

ankit-tailor commented Jun 22, 2023

mdvacca commented Jun 22, 2023

mdvacca commented Jun 23, 2023

stanwolverine commented Jun 23, 2023

rupam-seal commented Jun 28, 2023

cortinico commented Jun 29, 2023

rupam-seal commented Jun 29, 2023

stanwolverine commented Jun 29, 2023

mdvacca commented Jul 3, 2023

☂️ Help us Kotlin-ify React Native tests #37708

☂️ Help us Kotlin-ify React Native tests #37708

Comments

mdvacca commented Jun 5, 2023 • edited Loading

Description

How to migrate a test

Setting up your environment

Running your tests

Code formatting

List of tests to migrate

ankit-tailor commented Jun 6, 2023

cortinico commented Jun 6, 2023

okwasniewski commented Jun 6, 2023

hurali97 commented Jun 6, 2023

MohamedRejeb commented Jun 6, 2023 • edited Loading

fabioh8010 commented Jun 6, 2023

aymane-missouri-nw commented Jun 6, 2023

rozkminiacz commented Jun 6, 2023

TheMissouri commented Jun 6, 2023

siddarthkay commented Jun 6, 2023 • edited Loading

mateusz1913 commented Jun 6, 2023

tarunrajput commented Jun 6, 2023

pk-218 commented Jun 6, 2023

megatunger commented Jun 6, 2023

cortinico commented Jun 6, 2023

RyanGst commented Jun 6, 2023

fathonyfath commented Jun 6, 2023

jasokolowska commented Jun 6, 2023

stanwolverine commented Jun 21, 2023

mdvacca commented Jun 22, 2023 • edited Loading

ankit-tailor commented Jun 22, 2023

mdvacca commented Jun 22, 2023

mdvacca commented Jun 23, 2023

stanwolverine commented Jun 23, 2023

rupam-seal commented Jun 28, 2023

cortinico commented Jun 29, 2023

rupam-seal commented Jun 29, 2023

stanwolverine commented Jun 29, 2023

mdvacca commented Jul 3, 2023

mdvacca commented Jun 5, 2023 •

edited

Loading

MohamedRejeb commented Jun 6, 2023 •

edited

Loading

siddarthkay commented Jun 6, 2023 •

edited

Loading

mdvacca commented Jun 22, 2023 •

edited

Loading