Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted JavaScriptModuleRegistryTest java file to kotlin #38143

Conversation

stanwolverine
Copy link
Contributor

Summary:

Helping in Kotlin-ify React Native tests, Converted react/bridge/JavaScriptModuleRegistryTest.java to kotlin file

Changelog:

[INTERNAL] [CHANGED] - JavaScriptModuleRegistryTest.java file migrated from java to kotlin

Test Plan:

Tests should pass

./gradlew :packages:react-native:ReactAndroid:test

@facebook-github-bot
Copy link
Contributor

Hi @stanwolverine!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@analysis-bot
Copy link

analysis-bot commented Jun 30, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,047,496 +0
android hermes armeabi-v7a 8,296,776 +1
android hermes x86 9,563,672 +3
android hermes x86_64 9,405,967 +1
android jsc arm64-v8a 9,605,975 -2
android jsc armeabi-v7a 8,732,691 -2
android jsc x86 9,693,017 -1
android jsc x86_64 9,939,317 +0

Base commit: 5fd32d7
Branch: main

@mdvacca
Copy link
Contributor

mdvacca commented Jun 30, 2023

Hi @stanwolverine, thanks for working on this PR

We can't import this pull request because the author does not have a valid CLA signed. See above for instructions!

@stanwolverine
Copy link
Contributor Author

Hi @mdvacca , I have signed the valid CLA. It's taking time to reflect that in this PR. Maybe it will show up after sometime.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2023
Copy link
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@facebook-github-bot
Copy link
Contributor

@mdvacca has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Pranav-yadav Pranav-yadav added the Tests This PR adds or edits a test case. label Jul 1, 2023
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 3, 2023
@facebook-github-bot
Copy link
Contributor

@mdvacca merged this pull request in f90829f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tests This PR adds or edits a test case.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants