-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converted JavaScriptModuleRegistryTest java file to kotlin #38143
converted JavaScriptModuleRegistryTest java file to kotlin #38143
Conversation
Hi @stanwolverine! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Base commit: 5fd32d7 |
Hi @stanwolverine, thanks for working on this PR We can't import this pull request because the author does not have a valid CLA signed. See above for instructions! |
...-native/ReactAndroid/src/test/java/com/facebook/react/bridge/JavaScriptModuleRegistryTest.kt
Outdated
Show resolved
Hide resolved
Hi @mdvacca , I have signed the valid CLA. It's taking time to reflect that in this PR. Maybe it will show up after sometime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mdvacca has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
Helping in Kotlin-ify React Native tests, Converted react/bridge/JavaScriptModuleRegistryTest.java to kotlin file
Changelog:
[INTERNAL] [CHANGED] -
JavaScriptModuleRegistryTest.java
file migrated from java to kotlinTest Plan:
Tests should pass