fix: Removes interface only check from third party components GenerateThirdPartyFabricComponentsProvider

[Ubax]

Summary

Currently the codegen does not include component with field interfaceOnly set to true in the ThirdPartyFabricComponentsProvider.

These components need to be added to this file, so that non-core components can be used in fabric.

Changelog

[General [Fixed] - Fixes GenerateThirdPartyFabricComponentsProvider

Test Plan

Run codegen with component outside of core on iOS.

Check if components with and without interfaceOnly are added to RCTThirdPartyFabricComponentsProvider

[facebook-github-bot]

Hi @Ubax!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[pull-bot]

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 7745240

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dc5cae5
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,287,518	+778
android	hermes	armeabi-v7a	7,619,626	+792
android	hermes	x86	8,757,929	+970
android	hermes	x86_64	8,696,298	+953
android	jsc	arm64-v8a	9,675,961	+766
android	jsc	armeabi-v7a	8,664,762	+786
android	jsc	x86	9,631,889	+970
android	jsc	x86_64	10,227,845	+946

Base commit: dc5cae5
Branch: main

[sota000]

Thanks, @Ubax! cc: @sammy-SC

[sota000]

Ohh, I need the CLA to be added. I'll import it after that's added. cc: @Ubax

[sota000]

Just to get this back on your plate about the CLA.

[Ubax]

@sota000 I filled CLA

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ShikaSD]

hey, do you mind also updating test fixtures in the packages/react-native-codegen/src/generators/components/__tests__/ folder? Seems like updated generator (expectedly) generates a bit more things there :)

[Ubax]

Yeah sure

[Ubax]

@ShikaSD done

[facebook-github-bot]

@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[janicduplessis]

Awesome, I hit this issue too when trying the new architecture with an interfaceOnly component. I can confirm this fixes the issue.

[react-native-bot]

This pull request was successfully merged by @Ubax in 3e69022.

^{When will my fix make it into a release? | Upcoming Releases}