Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native code-gen > Add a C++ only TurboModule example (for Android/iOS/macOS/Windows) #35138

Closed

Conversation

christophpurrer
Copy link
Contributor

Summary:
Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 30, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39011736

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Oct 30, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39011736

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 30, 2022
…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

fbshipit-source-id: d4ed6cecc00dafd1f478e4d3ea58611231635772
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 5, 2022
… builds

Summary:
This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in facebook#35138

Changelog: [Internal]

Differential Revision: D41057630

fbshipit-source-id: 51e8686461788c7a6f3644932abd99dff9e15edf
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 5, 2022
… builds (facebook#35211)

Summary:
Pull Request resolved: facebook#35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in facebook#35138

Changelog: [Internal]

Differential Revision: D41057630

fbshipit-source-id: 5a6199043566d9c081f9a03fef607fed904049a4
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 5, 2022
… builds (facebook#35211)

Summary:
Pull Request resolved: facebook#35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in facebook#35138

Changelog: [Internal]

Differential Revision: D41057630

fbshipit-source-id: 1d2a479cbb29d472fcbc577ed40ebdf02396986e
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 5, 2022
… builds (facebook#35211)

Summary:
Pull Request resolved: facebook#35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in facebook#35138

Changelog: [Internal]

Differential Revision: D41057630

fbshipit-source-id: 74d2d1f24bd0dd156cf5268d08af458393e574e3
facebook-github-bot pushed a commit that referenced this pull request Nov 7, 2022
… builds (#35211)

Summary:
Pull Request resolved: #35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in #35138

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D41057630

fbshipit-source-id: 303881a63eb82f0fe8dfe10e533043a6eedb3d11
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39011736

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 7, 2022
…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

fbshipit-source-id: 8465d3cb9d191e57ad6600f633a13914cb77895f
@analysis-bot
Copy link

analysis-bot commented Nov 7, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,101,041 +31,751
android hermes armeabi-v7a 6,470,878 +29,438
android hermes x86 7,518,668 +34,305
android hermes x86_64 7,377,112 +33,264
android jsc arm64-v8a 8,965,563 +31,324
android jsc armeabi-v7a 7,697,371 +28,995
android jsc x86 9,028,237 +33,855
android jsc x86_64 9,506,034 +32,819

Base commit: ea1d729
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39011736

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 7, 2022
…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

fbshipit-source-id: ae51d375c2056b977c27a9141a681101df68e211
@pull-bot
Copy link

pull-bot commented Nov 7, 2022

PR build artifact for 96d84db is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39011736

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 7, 2022
…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

fbshipit-source-id: 8ff625c5ec9bbca188f4dfc74e9f19ebe3721da2
@pull-bot
Copy link

pull-bot commented Nov 7, 2022

PR build artifact for 7c99667 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39011736

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 8, 2022
…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

fbshipit-source-id: d792d3b5b73ff0434e2e49165d7dcf5b89161927
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 8, 2022
…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

fbshipit-source-id: 4d666844e94068e4ddc4c198fa29d788b6bd248c
@pull-bot
Copy link

pull-bot commented Nov 8, 2022

PR build artifact for b960977 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39011736

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 8, 2022
…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

fbshipit-source-id: 56db0d5d7f5ca46a342772cb2de5203de1938df1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39011736

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 8, 2022
…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

fbshipit-source-id: e60e2120254fe1a64f2e649e833320a36467ec0c
@pull-bot
Copy link

pull-bot commented Nov 8, 2022

PR build artifact for ad118d2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Differential Revision: D39011736

fbshipit-source-id: a3091891cc8cec927b0914d6342d2873df953fdb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39011736

@pull-bot
Copy link

pull-bot commented Nov 8, 2022

PR build artifact for a4f286a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

kelset pushed a commit that referenced this pull request Nov 22, 2022
… builds (#35211)

Summary:
Pull Request resolved: #35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in #35138

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D41057630

fbshipit-source-id: 303881a63eb82f0fe8dfe10e533043a6eedb3d11
kelset pushed a commit that referenced this pull request Nov 22, 2022
…id/iOS/macOS/Windows) (#35138)

Summary:
Pull Request resolved: #35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Reviewed By: javache

Differential Revision: D39011736

fbshipit-source-id: 84c833d8540671fde8505f1aeb0265074b248730
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
… builds (facebook#35211)

Summary:
Pull Request resolved: facebook#35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in facebook#35138

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D41057630

fbshipit-source-id: 303881a63eb82f0fe8dfe10e533043a6eedb3d11
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…id/iOS/macOS/Windows) (facebook#35138)

Summary:
Pull Request resolved: facebook#35138

Changelog:

[General][Added] - Add a C++ only TurboModule example (for Android/iOS/macOS/Windows)

react-native@0.69 introduced a new bridging layer to ease integration for pure C++ TurboModules using C++ std:: types directly instead of the lower level jsi:: types:
https://github.com/facebook/react-native/tree/v0.69.0/ReactCommon/react/bridging

This bridging layer can be used in JSI functions or more conveniently in C++ TurboModules.

Here is a example of an C++ only TurboModule which will work on Android and iOS and macOS/Windows (using microsoft/react-native-macos|windows) only using flow/TypeScript and standard C++ types.

C++ only TurboModules are very handy as they do not require to work with JSI APIs - instead std:: or custom C++ can by used.

Reviewed By: javache

Differential Revision: D39011736

fbshipit-source-id: 84c833d8540671fde8505f1aeb0265074b248730
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants