Allow react-native and expo to build when using GNU coreutils

[shreeve]

Summary

See the issue at #32432 (comment)

This fixes a bizarre issue when using the GNU coreutils tools. There are very minor differences in the standard BSD based command-line tools on macOS and the GNU coreutils versions. In particular, the cp command has slightly different semantics across these two versions. This commit normalizes those differences and allows the GNU coreutils cp command to work the same as the BSD version, thus fixing a hard to track down bug.

Changelog

[General] [Fixed] - Allow GNU coreutils to be used to build projects

Test Plan

This change allows the use of the system or GNU coreutils verson of cp.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,103,561	+0
android	hermes	armeabi-v7a	6,471,886	+0
android	hermes	x86	7,521,203	+0
android	hermes	x86_64	7,380,081	+0
android	jsc	arm64-v8a	8,968,399	+0
android	jsc	armeabi-v7a	7,699,505	+0
android	jsc	x86	9,030,706	+0
android	jsc	x86_64	9,508,749	+0

Base commit: 2d1d61a
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 2d1d61a
Branch: main

[pull-bot]

PR build artifact for ea27953 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for ea27953 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[cortinico]

Can you please fix the CLA?

Also you can you please clarify why this is needed. We're copying a folder, I'm not sure we want to copy /.

[shreeve]

@cortinico - Here's a quick summary of how BSD cp (default on macOS) and GNU cp (default on Linux and often used on macOS) behave with the cp -R src dst and cp -R src/. dst commands:

# setup
mkdir -p /tmp/cp/{bad,fix}/{bsd,gnu}/{src,dst}
touch    /tmp/cp/{bad,fix}/{bsd,gnu}/src/{1,2,3,4}.txt

# Starting point, with all files in their 'src' directory:
tree     /tmp/cp

/tmp/cp
├── bad
│   ├── bsd
│   │   ├── dst
│   │   └── src
│   │       ├── 1.txt
│   │       ├── 2.txt
│   │       ├── 3.txt
│   │       └── 4.txt
│   └── gnu
│       ├── dst
│       └── src
│           ├── 1.txt
│           ├── 2.txt
│           ├── 3.txt
│           └── 4.txt
└── fix
    ├── bsd
    │   ├── dst
    │   └── src
    │       ├── 1.txt
    │       ├── 2.txt
    │       ├── 3.txt
    │       └── 4.txt
    └── gnu
        ├── dst
        └── src
            ├── 1.txt
            ├── 2.txt
            ├── 3.txt
            └── 4.txt

14 directories, 16 files

# bad method (uses "src/")
gnu-cp -R /tmp/cp/bad/gnu/src/  /tmp/cp/bad/gnu/dst
bsd-cp -R /tmp/cp/bad/bsd/src/  /tmp/cp/bad/bsd/dst

# fix method (uses "src/.")
gnu-cp -R /tmp/cp/fix/gnu/src/. /tmp/cp/fix/gnu/dst
bsd-cp -R /tmp/cp/fix/bsd/src/. /tmp/cp/fix/bsd/dst

# Show result, see how gnu/src was copied to gnu/dst/src
# But, using "src/." works for both gnu and bsd
tree /tmp/cp

/tmp/cp
├── bad
│   ├── bsd
│   │   ├── dst
│   │   │   ├── 1.txt
│   │   │   ├── 2.txt
│   │   │   ├── 3.txt
│   │   │   └── 4.txt
│   │   └── src
│   │       ├── 1.txt
│   │       ├── 2.txt
│   │       ├── 3.txt
│   │       └── 4.txt
│   └── gnu
│       ├── dst
│       │   └── src
│       │       ├── 1.txt
│       │       ├── 2.txt
│       │       ├── 3.txt
│       │       └── 4.txt
│       └── src
│           ├── 1.txt
│           ├── 2.txt
│           ├── 3.txt
│           └── 4.txt
└── fix
    ├── bsd
    │   ├── dst
    │   │   ├── 1.txt
    │   │   ├── 2.txt
    │   │   ├── 3.txt
    │   │   └── 4.txt
    │   └── src
    │       ├── 1.txt
    │       ├── 2.txt
    │       ├── 3.txt
    │       └── 4.txt
    └── gnu
        ├── dst
        │   ├── 1.txt
        │   ├── 2.txt
        │   ├── 3.txt
        │   └── 4.txt
        └── src
            ├── 1.txt
            ├── 2.txt
            ├── 3.txt
            └── 4.txt

15 directories, 32 files

[shreeve]

@cortinico - You are right, that second "/." isn't needed. But, the first one is critical for copying to work correctly across BSD and GNU versions of the cp command.

[pull-bot]

PR build artifact for 57d6e1b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for 57d6e1b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[cortinico]

/rebase

[shreeve]

Should be synced up now 👍🏻

[cortinico]

Should be synced up now 👍🏻

Great 👍 Let's wait for a CI run and we can import/merge it

[pull-bot]

PR build artifact for d240dbc is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for d240dbc is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @shreeve in f5e5274.

^{When will my fix make it into a release? | Upcoming Releases}