Add CircleCI tests for use frameworks #35497

cipolleschi · 2022-11-28T15:20:15Z

Summary:
In 0.71.0-RC.2, we had a regression in use_frameworks!.

This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests.

Changelog

[iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch

Differential Revision: D41551288

facebook-github-bot · 2022-11-28T15:20:38Z

This pull request was exported from Phabricator. Differential Revision: D41551288

facebook-github-bot · 2022-11-28T15:30:20Z

This pull request was exported from Phabricator. Differential Revision: D41551288

Summary: Pull Request resolved: facebook#35497 In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests. ## Changelog [iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch Reviewed By: cortinico Differential Revision: D41551288 fbshipit-source-id: 78b3cf2d7f48977b5fb7d5f6053da919a390027f

analysis-bot · 2022-11-28T15:53:26Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 8b00b4f
Branch: main

facebook-github-bot · 2022-11-28T15:55:39Z

This pull request was exported from Phabricator. Differential Revision: D41551288

Summary: Pull Request resolved: facebook#35497 In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests. ## Changelog [iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch Reviewed By: cortinico Differential Revision: D41551288 fbshipit-source-id: 933600e321eea4a38730ecb30786e4c4038501d1

facebook-github-bot · 2022-11-28T16:03:06Z

This pull request was exported from Phabricator. Differential Revision: D41551288

Summary: Pull Request resolved: facebook#35497 In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests. ## Changelog [iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch Reviewed By: cortinico Differential Revision: D41551288 fbshipit-source-id: 2974da782ac248e19ba18e0f391537a5c129142c

mikehardy

This is fantastic - adding the use_frameworks CI job at least up to the point of what we know should work (static linkage, -Flipper, -NewArch) should be a big help, and you've got the infra in at the same time to toggle those on as possible in the future. Huge +1

analysis-bot · 2022-11-28T16:25:06Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,102,470	-2
android	hermes	armeabi-v7a	6,471,223	+2
android	hermes	x86	7,520,657	-1
android	hermes	x86_64	7,379,165	-12
android	jsc	arm64-v8a	8,967,382	+1
android	jsc	armeabi-v7a	7,698,735	+0
android	jsc	x86	9,030,062	-2
android	jsc	x86_64	9,507,699	-2

Base commit: 6c33fd1
Branch: main

pull-bot · 2022-11-28T16:35:23Z

PR build artifact for 7ff4de3 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-28T16:37:49Z

PR build artifact for 7ff4de3 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-11-28T16:48:15Z

This pull request was exported from Phabricator. Differential Revision: D41551288

Summary: Pull Request resolved: facebook#35497 In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests. ## Changelog [iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch Reviewed By: cortinico Differential Revision: D41551288 fbshipit-source-id: aa712975800247282f188255459483422ea387cf

pull-bot · 2022-11-28T17:20:00Z

PR build artifact for 2faa0d7 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-28T17:26:26Z

PR build artifact for 2faa0d7 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Summary: Pull Request resolved: facebook#35497 In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests. ## Changelog [iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch Reviewed By: cortinico Differential Revision: D41551288 fbshipit-source-id: 0a98c65f9908e3fe6356019e1cbe62c4477f6c67

facebook-github-bot · 2022-11-28T17:33:18Z

This pull request was exported from Phabricator. Differential Revision: D41551288

pull-bot · 2022-11-28T18:09:15Z

PR build artifact for 967cb59 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-11-28T20:36:12Z

This pull request was exported from Phabricator. Differential Revision: D41551288

Summary: Pull Request resolved: facebook#35497 In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests. ## Changelog [iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch Reviewed By: cortinico Differential Revision: D41551288 fbshipit-source-id: 682178bc0d39b11ce4b3c91bf4a206130c3e3106

pull-bot · 2022-11-28T21:05:47Z

PR build artifact for bc1744c is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-28T21:12:05Z

PR build artifact for bc1744c is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: https://internalfb.com/D41548985 Pulled By: cipolleschi fbshipit-source-id: 5ff5b0eaf43fea4abd67f091482bd80fc11ec05c

Summary: In 0.71.0-RC.2, we had a regression in `use_frameworks!`. The `use_frameworks! :linkage => :static` use to work fine with the Old Architecture. We modified how the `React-bridging` pod is configured and, now those are broken. This change make sure to use the right imports for React-bridging. ## Changelog [iOS][Changed] - Fix imports in React Bridging for Old Arch and frameworks Differential Revision: https://internalfb.com/D41551103 fbshipit-source-id: d16292eb76f84a6e5037c5ec501adcad8583ab9d

Summary: In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This brings back JSIDynamic and JSI together because the current setup is not compatible with iOS frameworks ## Changelog [iOS][Added] - Bring back JSIDynamic and JSI Differential Revision: https://internalfb.com/D41557823 fbshipit-source-id: a7d36f08f608c30b399d1a3907422226ebff718d

Summary: Pull Request resolved: facebook#35497 In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests. ## Changelog [iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch Reviewed By: cortinico Differential Revision: D41551288 fbshipit-source-id: 5db2a3150d171bd08618e14c1fffab347aaee4b5

facebook-github-bot · 2022-11-28T22:33:28Z

This pull request was exported from Phabricator. Differential Revision: D41551288

pull-bot · 2022-11-28T23:04:34Z

PR build artifact for 6e9b3aa is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-28T23:10:06Z

PR build artifact for 6e9b3aa is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

mikehardy · 2022-11-29T15:56:01Z

✔️ All checks have passed -> 🏆 @cipolleschi thank you!

react-native-bot · 2022-11-29T17:05:11Z

This pull request was successfully merged by @cipolleschi in 4e8526c.

^{When will my fix make it into a release? | Upcoming Releases}

gosham2016 · 2022-11-29T17:16:08Z

Класс

Summary: Pull Request resolved: #35497 In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests. ## Changelog [iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch Reviewed By: cortinico Differential Revision: D41551288 fbshipit-source-id: 531fabb1a7b6aceab2926bb83cf2887129df1776

Summary: Pull Request resolved: facebook#35497 In 0.71.0-RC.2, we had a regression in `use_frameworks!`. This adds some CircleCI jobs to make sure we do not regress on those. It also updates the template to support these tests. ## Changelog [iOS][Added] - CircleCI jobs to keep the use_framework! setup in check for the Old Arch Reviewed By: cortinico Differential Revision: D41551288 fbshipit-source-id: 531fabb1a7b6aceab2926bb83cf2887129df1776

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 28, 2022

react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Nov 28, 2022

cipolleschi force-pushed the export-D41551288 branch from ffb349c to f98e551 Compare November 28, 2022 15:30

cipolleschi force-pushed the export-D41551288 branch from f98e551 to 1506592 Compare November 28, 2022 15:56

cipolleschi force-pushed the export-D41551288 branch from 1506592 to 7ff4de3 Compare November 28, 2022 16:03

mikehardy approved these changes Nov 28, 2022

View reviewed changes

cipolleschi force-pushed the export-D41551288 branch from 7ff4de3 to 2faa0d7 Compare November 28, 2022 16:48

cipolleschi force-pushed the export-D41551288 branch from 2faa0d7 to 967cb59 Compare November 28, 2022 17:33

cipolleschi force-pushed the export-D41551288 branch from 2437cb7 to bc1744c Compare November 28, 2022 20:36

Riccardo Cipolleschi and others added 4 commits November 28, 2022 14:31

cipolleschi force-pushed the export-D41551288 branch from bc1744c to 6e9b3aa Compare November 28, 2022 22:33

facebook-github-bot closed this in 4e8526c Nov 29, 2022

react-native-bot added the Merged This PR has been merged. label Nov 29, 2022

cipolleschi mentioned this pull request Aug 16, 2023

cipolleschi/add maven polling #39039

Merged

cipolleschi mentioned this pull request Sep 21, 2023

[LOCAL] Copy hermes ruby files to hermes folder in local E2E test #39577

Merged

cipolleschi mentioned this pull request Oct 11, 2023

cipolleschi/fix CI #40793

Merged

cipolleschi mentioned this pull request Nov 1, 2023

[RN][CI]Update node installation on debian (0.71) #41277

Merged

This was referenced Jan 8, 2024

[0.71][RN][General] Migrate boost download url away from JFrog #42177

Merged

[RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! #42229

Merged

cipolleschi mentioned this pull request Mar 6, 2024

[RN][iOS][0.71] Fix flipper for Xcode 15.3 #43345

Merged

cipolleschi mentioned this pull request Apr 5, 2024

cipolleschi/fix yoga archive 0.71 #43895

Closed

cipolleschi mentioned this pull request Apr 26, 2024

[iOS][Privacy Manifest] Set up privacy manifest for React Native 0.71 #44281

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CircleCI tests for use frameworks #35497

Add CircleCI tests for use frameworks #35497

cipolleschi commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

analysis-bot commented Nov 28, 2022 •

edited

Loading

facebook-github-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

mikehardy left a comment

analysis-bot commented Nov 28, 2022 •

edited

Loading

pull-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

mikehardy commented Nov 29, 2022

react-native-bot commented Nov 29, 2022

gosham2016 commented Nov 29, 2022

Add CircleCI tests for use frameworks #35497

Add CircleCI tests for use frameworks #35497

Conversation

cipolleschi commented Nov 28, 2022

Changelog

facebook-github-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

analysis-bot commented Nov 28, 2022 • edited Loading

facebook-github-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

mikehardy left a comment

Choose a reason for hiding this comment

analysis-bot commented Nov 28, 2022 • edited Loading

pull-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

facebook-github-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

pull-bot commented Nov 28, 2022

mikehardy commented Nov 29, 2022

react-native-bot commented Nov 29, 2022

gosham2016 commented Nov 29, 2022

analysis-bot commented Nov 28, 2022 •

edited

Loading

analysis-bot commented Nov 28, 2022 •

edited

Loading