Properly expose jscexecutor as a prefab target
#35521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Inside RC3 the jscexecutor target was prepared for prefab consumption but not properly exposed. This was not caught by the CI as we're not effectively using this target, but some of our popular libraries do (i.e. Reanimated). I'm exposing it here. Changelog: [Internal] [Changed] - Properly expose `jscexecutor` as a prefab target Reviewed By: javache Differential Revision: D41648349 fbshipit-source-id: 499d54b4ff219024690eb80f8ddcebd9708a7ac2
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41648349 |
Base commit: 46fe963 |
Base commit: 5f01622 |
|
PR build artifact for 67a4e87 is ready. |
|
PR build artifact for 67a4e87 is ready. |
|
This pull request was successfully merged by @cortinico in da4243b. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Dec 13, 2022
Summary: Pull Request resolved: #35521 Inside RC3 the jscexecutor target was prepared for prefab consumption but not properly exposed. This was not caught by the CI as we're not effectively using this target, but some of our popular libraries do (i.e. Reanimated). I'm exposing it here. Changelog: [Internal] [Changed] - Properly expose `jscexecutor` as a prefab target Reviewed By: javache Differential Revision: D41648349 fbshipit-source-id: 1a04bc21aa50eece304828ce1d99ae795a51af48
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35521 Inside RC3 the jscexecutor target was prepared for prefab consumption but not properly exposed. This was not caught by the CI as we're not effectively using this target, but some of our popular libraries do (i.e. Reanimated). I'm exposing it here. Changelog: [Internal] [Changed] - Properly expose `jscexecutor` as a prefab target Reviewed By: javache Differential Revision: D41648349 fbshipit-source-id: 1a04bc21aa50eece304828ce1d99ae795a51af48
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Inside RC3 the jscexecutor target was prepared for prefab consumption
but not properly exposed.
This was not caught by the CI as we're not effectively using this target,
but some of our popular libraries do (i.e. Reanimated). I'm exposing it here.
Changelog:
[Internal] [Changed] - Properly expose
jscexecutoras a prefab targetReviewed By: javache
Differential Revision: D41648349