Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch order of onSelectionChange and onChange events on iOS #35603

Closed
wants to merge 1 commit into from
Closed

Switch order of onSelectionChange and onChange events on iOS #35603

wants to merge 1 commit into from

Conversation

s77rt
Copy link
Contributor

@s77rt s77rt commented Dec 9, 2022

Summary

Switched order of onSelectionChange and onChange events on iOS

This was already fixed but for fabric only https://github.com/facebook/react-native/blob/main/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm#L36-L46

This PR is a complementary of 7b48899

Fixes #28865

Changelog

[IOS] [FIXED] - onSelectionChange() is fired before onChange() on multiline TextInput

Test Plan

Reproduce the minimal example provided here #28865
Verify that the events order is onChange then onSelectionChange with no duplicates

@facebook-github-bot
Copy link
Contributor

Hi @s77rt!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,783,821 +0
android hermes armeabi-v7a 7,101,547 +0
android hermes x86 8,257,527 +0
android hermes x86_64 8,115,352 +0
android jsc arm64-v8a 8,976,992 +0
android jsc armeabi-v7a 7,708,149 +0
android jsc x86 9,040,016 +0
android jsc x86_64 9,517,383 +0

Base commit: 43e7f50
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 43e7f50
Branch: main

@pull-bot
Copy link

pull-bot commented Dec 9, 2022

PR build artifact for 07b2207 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Dec 9, 2022

PR build artifact for 07b2207 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@s77rt
Copy link
Contributor Author

s77rt commented Dec 9, 2022

Closing and Reopening to trigger CLA Check

@s77rt s77rt closed this Dec 9, 2022
@s77rt s77rt reopened this Dec 9, 2022
@s77rt s77rt mentioned this pull request Dec 9, 2022
Closed
@react-native-bot react-native-bot added the No CLA Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@react-native-bot react-native-bot removed the No CLA Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2022
@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@sobitneupane sobitneupane mentioned this pull request Dec 14, 2022
Closed
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 14, 2022
@facebook-github-bot
Copy link
Contributor

@dmytrorykun merged this pull request in 64475ae.

kelset pushed a commit that referenced this pull request Jan 19, 2023
@s77rt @kelset
Switch order of onSelectionChange and onChange events on iOS (#35603)
112bfee 
Summary:
Switched order of onSelectionChange and onChange events on iOS

This was already fixed but for fabric only https://github.com/facebook/react-native/blob/main/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm#L36-L46

This PR is a complementary of 7b48899

Fixes #28865

## Changelog

[IOS] [FIXED] - onSelectionChange() is fired before onChange() on multiline TextInput

Pull Request resolved: #35603

Test Plan:
Reproduce the minimal example provided here #28865
Verify that the events order is onChange then onSelectionChange with no duplicates

Reviewed By: cipolleschi

Differential Revision: D41947673

Pulled By: dmytrorykun

fbshipit-source-id: cf452a6101400b1b54295c83fa7735449d91e781
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2023
Open
@eVoloshchak eVoloshchak mentioned this pull request Apr 19, 2023
Closed
6 tasks
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@s77rt @OlimpiaZurek
Switch order of onSelectionChange and onChange events on iOS (faceboo…
55cca5c 
…k#35603)

Summary:
Switched order of onSelectionChange and onChange events on iOS

This was already fixed but for fabric only https://github.com/facebook/react-native/blob/main/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm#L36-L46

This PR is a complementary of facebook@7b48899

Fixes facebook#28865

## Changelog

[IOS] [FIXED] - onSelectionChange() is fired before onChange() on multiline TextInput

Pull Request resolved: facebook#35603

Test Plan:
Reproduce the minimal example provided here facebook#28865
Verify that the events order is onChange then onSelectionChange with no duplicates

Reviewed By: cipolleschi

Differential Revision: D41947673

Pulled By: dmytrorykun

fbshipit-source-id: cf452a6101400b1b54295c83fa7735449d91e781
@mollfpr mollfpr mentioned this pull request Aug 9, 2023
Closed
6 tasks
@allroundexperts allroundexperts mentioned this pull request Aug 11, 2023
Closed
6 tasks
@cipolleschi cipolleschi mentioned this pull request Aug 16, 2023
Merged
@shubham1206agra shubham1206agra mentioned this pull request Aug 27, 2023
Closed
6 tasks
@cipolleschi cipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
This was referenced Jan 8, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Mar 6, 2024
Merged
@cipolleschi cipolleschi mentioned this pull request Apr 5, 2024
Closed
@cipolleschi cipolleschi mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
5 participants
@s77rt @facebook-github-bot @analysis-bot @pull-bot @react-native-bot