[LOCAL] fix: use REACT_NATIVE_CI instead of CI envvar #35605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
requested changes
Dec 9, 2022
There was a problem hiding this comment.
I think we should also update these lines:
- https://github.com/facebook/react-native/blob/0.71-stable/scripts/test-e2e-local.js#L100
- https://github.com/facebook/react-native/blob/0.71-stable/scripts/cocoapods/jsengine.rb#L75
- https://github.com/facebook/react-native/blob/0.71-stable/scripts/cocoapods/__tests__/jsengine-test.rb#L30
- https://github.com/facebook/react-native/blob/0.71-stable/scripts/cocoapods/__tests__/jsengine-test.rb#L136
cortinico
reviewed
Dec 9, 2022
dmytrorykun
changed the title
cipolleschi
approved these changes
Dec 9, 2022
cipolleschi
requested changes
Dec 9, 2022
cipolleschi
approved these changes
Dec 9, 2022
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
REACT_NATIVE_CIinstead ofCIenvironment variable to trigger building Hermes from source on CircleCI.CIenvvar is defined in many other CIs, which may lead to undesirable behavior: #35547Changelog
[INTERNAL] [CHANGED] - Use
REACT_NATIVE_CIinstead ofCIenvironment variable to trigger building Hermes from source on CircleCI.Test Plan
pod installandCI=true pod installboth consume Hermes prebuilt if available.REACT_NATIVE_CI=true pod installbuilds Hermes from tag specified in.hermesversion.CircleCI.